[Bug 2300] Review request: freecad - A general purpose 3D CAD modeler

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2300

--- Comment #36 from Richard <hobbes1069 at gmail.com> 2012-07-05 01:40:54 CEST ---
(In reply to comment #35)
> Issues
> ======
> [!]  Licensing. There are some v3 and LGPL v2.1 as well. Since this
>      isn't a library, using LGPL isn't that useful. Maybe the simplest
>      solution is to set license to GPLv3+, promoting all LGPL to GPL,
>      and promoting GPL v2+ to GPLv3+

Fixed. I didn't know we could do that :) Have I mentioned I'm weak on
licensing?


> [!]  License files, at least licensing.lib and License.txt is not in
>      %doc. Please recheck this.

Added but do we still have a problem? I thought LGPL wasn't intended to cover
applications?


> [!]  Shouldn't this package require hicolor-icons-theme?!

Oops! Fixed.


> [!]  No blocker, but I'm uneasy with the manpage symlinking. Basically,
>      you set up dangling symlinks, trusting rpmbuild to satisfy it 
>      by creating the gz files. But what if rpmbuild decides on another 
>      compressing scheme? I'd prefer to just copy the manpages or, better,
>      to provide dummy "See instead" for the other pages.

If that were to happen wouldn't the build fail? I don't think this is an issue
but I'm not sure what the precedence exist here.


> [!]  No blocker either in case %global doesn't work in this case. But
>      if possible %global should be used instead if %define

Yup, those are the ones John added so I left them alone. Since I won't be using
them at all for building on RPM fusion I'm tempted to leave it alone. I've
noticed there's still a lot in the guidelines that says to use %define instead
of %global.


> [!]  If possible, try to get rid of the unused-direct-shlib-dependency
>      warnings from installed package. Is the Wl,as-needed really in effect?
>      It's >1200 of these :)

I should have caught that, fixed.


> [!]  Inform upstream about missing license files (GPLv2, GPLv3), bad

I decided to start with a forum message to see if a bug report was warranted.
I'll follow up with one if needed.

https://sourceforge.net/apps/phpbb/free-cad/viewtopic.php?f=4&t=2784


>      FSF address and shared-lib-calls-exit' 

https://sourceforge.net/apps/mantisbt/free-cad/view.php?id=777

One of the new license files has DOS line endings so I'll post new links after
I get that sorted out.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.