[Bug 2420] pSX - An emulator which fully emulates the Sony Playstation.

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2420

Jeremy Newton <alexjnewt at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alexjnewt at hotmail.com

--- Comment #4 from Jeremy Newton <alexjnewt at hotmail.com> 2012-07-19 04:47:18 CEST ---
Just some comments:

- If you are not yet sponsored in RPMFusion or Fedora, can you please block bug
30, so a reviewer can know you need sponsorship and so a potential sponsor can
find you easier.

-Perhaps Freeware isn't the best license to use as it can be confused with Free
Software. Redistributable, Proprietary or Non-free are usually less
misinterpreted alternatives.

-The build require of hicolor-icon-theme is unnecessary, as it's only something
needed for installation purposes, thus you only need the regular require not
both.

-The changelog is meant for use of noting what has been done; known bugs should
not be included. If you do wish to add a known bug to the spec, please do it as
a form of a comment near the top section of the spec file, such as above the
description.

-You need to give the RPMLint output for both the binary and the SRPM. Most of
these warnings can be safely ignored but there is a warning about the summary
that should be fixed.

-For the purpose of review, you do not need to sign your packages, though to my
knowledge there isn't any reason you can't if you wish to do so anyway.

-Though I'm not sure, I believe the Group tag is no longer used anymore.

I haven't taken a full look into it, so that's all I can help with so far.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.