[Bug 1901] Review request: bino - 3D video player

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=1901

--- Comment #23 from Jaroslav Škarvada <jskarvad at redhat.com> 2012-03-01 11:21:31 CET ---
(In reply to comment #22)
Thanks for the review. Updated files:
http://jskarvad.fedorapeople.org/bino-1.2.1-2.fc16.src.rpm
http://jskarvad.fedorapeople.org/bino.spec

> Issues:
> [!]: MUST Package consistently uses macros (instead of hard-coded directory
>      names).
>      Note: Using both %{buildroot} and $RPM_BUILD_ROOT
Fixed

> [!]  SHOULD The ld-patch needs some kind of justification, an upstream bug
>      reference or a comment.
Added comment, this patch is required in order to build due to Fedora DSO
linkage change. This patch has been accepted by upstream and is not needed for
their devel release.

> [!]  MUST The %post and %preun texinfo snippets needs corresponding
>      Requires(post): info  and Requires(preun): info.
Fixed

> [!]  MUST: The License: tag should be updated to reflect the licenses
>      in the package. Removing the pkg stuff in %prep might possibly
>      make things simpler. Using system icons instead of src/icons might
>      also help. Non-GPLv3+ licenses includes pkg/* and src/icons*/*.
>      Some kind of license breakdown is probably needed.
I am not expert about licensing, but I am not sure if there was any problem
(but I implemented all the proposed changes):
* The pkg stuff is not used/released in the RPM binary package, thus I think it
was OK according to:
http://fedoraproject.org/wiki/Licensing/FAQ#Does_the_License:_tag_cover_the_SRPM_or_the_binary_RPM.3F
Even after the removal, the source code is still distributed in the srpm
package. So I am not sure if the proposed change resolves anything.

* For the oxygen icons, IMHO they are licensed under LGPLv3+ thus we probably
don't need to explicitly note this because the resulting work is released under
GPLv3+. I used the following reference:
http://fedoraproject.org/wiki/Licensing/FAQ#What_is_.22effective_license.22_and_do_I_need_to_know_that_for_the_License:_tag.3F
http://fedoraproject.org/wiki/Licensing/FAQ#How_should_I_handle_multiple_licensing_situations.3F

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.