[Bug 2190] Review request: AtomicParsley - Command-Line Program to Read and Set iTunes-style Metadata Tags

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2190

--- Comment #3 from Avi Alkalay <avi at unix.sh> 2012-03-02 20:27:28 CET ---
(In reply to comment #1)
> Dont use the %__rm, %__cp macros, use simple 'rm', 'cp' 'c++' instead
> See http://fedoraproject.org/wiki/Packaging:Guidelines#Macros

Fixed.


> The License: tag does not reflect the fact that some code is MIT/X11
> licensed. See http://fedoraproject.org/wiki/Packaging:Guidelines#Licensing.

Couldn't find a nothing on the source that says MIT/X11 license.



> You can't add COPYING yourself, you must contact upstream about that. And
> upstream has already a COPYING in place. Are you replacing it? This is not
> possible either for legal reasons.  After all, it's their code. If you have
> problem with the fsf-address lint warning, just report to upstream, bring the
> link (e. g., bugtracker  ticket) in here and live with the warning.

This is old code, there is no upstream. GNU office has moved to another address
but the license file included reflects the old address and rpmlint is
complaining. I'm just overwriting with the new file because of this small
problem.



> Remove Buildroot:, %clean, %defattr. These are not used in Fedora.

Fixed.


> The Source0 url is wrong, it just fetches a html page. See
> http://fedoraproject.org/wiki/Packaging:SourceURL, note the sourceforge
> chapter.

Fixed.


> Rpmlint shows empty debug package. Probably related to that you remove the -g
> option to g++. You should not do that, generate debug info and let rpmbuild
> strip to the debug package instead. And run rpmlint on the debug package as
> well.

I can't generate debug packages. How to do that? I even removed the '-s'
(strip) from 'install' but no debug package is generated.


> You don't need to require c++, make etc. 
> See: http://fedoraproject.org/wiki/Packaging:Guidelines#Exceptions_2

Fixed.


> Write the sed code on one line (note there's only the last one left
> when you're done)
> sed -i -e 's/g++/$CXX/g' -e 's/-g//g' -e 's/-O2/$OPTFLAGS/g' build

Fixed.


> Write the %doc list on one line: 
> %doc COPYING  AP\ buglist.txt  Using\ AtomicParsley.rtf

Fixed.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.