[Bug 2216] New: Review request: Not Tetris 2 - Classic Tetris mixed with physics

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2216

             Bug #: 2216
           Summary: Review request: Not Tetris 2 - Classic Tetris mixed
                    with physics
    Classification: Unclassified
           Product: Package Reviews
           Version: Current
          Platform: All
        OS/Version: GNU/Linux
            Status: NEW
          Severity: normal
          Priority: P5
         Component: Review Request
        AssignedTo: rpmfusion-package-review at rpmfusion.org
        ReportedBy: yajo.sk8 at gmail.com
                CC: rpmfusion-package-review at rpmfusion.org


A good reason to close bug #2213.

Please see http://www.mediafire.com/?upnigcka4ax7cmh to download the SRPM.

This is my first package.

Description
-----------
Not Tetris 2 is the spiritual successor of the classic Tetris mixed with
physics. The result is a fun spinoff in which blocks are no longer bound to the
usual grid. Blocks can be rotated and placed at any angle, resulting in a
complete mess if not careful. And with the newest cutting edge technology, Not
Tetris 2 allows line clears when the lines are sufficiently filled. The old
mode is still available for play and is now called Stack.

Why not in Fedora
-----------------
It depends on LÖVE, which depends on mpg123.

RPMLint output
--------------
> nottetris.src: W: spelling-error Summary(es) Tetris -> Tetáis, Tetéis, Te tris
> nottetris.src: W: spelling-error %description -l es Not -> Ton, No, Nota
No spell errors there.

> nottetris.src: W: invalid-license CC-BY-NC-SA
> nottetris.noarch: W: invalid-license CC-BY-NC-SA
That's the license, like it or not.

> nottetris.src: W: no-%build-section
Unneeded. It's a script.

> nottetris.noarch: W: spelling-error Summary(es) Tetris -> Tetáis, Tetéis, Te tris
> nottetris.noarch: W: spelling-error %description -l es Not -> Ton, No, Nota
No spell errors there.

> nottetris.noarch: E: script-without-shebang /usr/share/applications/nottetris.desktop
Desktop files need shebangs?

> nottetris.noarch: W: no-manual-page-for-binary nottetris
No idea of how to do this, honestly.

SPEC file
---------
Name:           nottetris
Version:        2.0
Release:        1%{?dist}
Summary:        Classic Tetris mixed with physics
Summary(es):    Tetris clásico mezclado con física
Group:          Amusements/Games
BuildArch:      noarch

License:        CC-BY-NC-SA
URL:            http://stabyourself.net/%{name}2/
Source0:       
http://stabyourself.net/dl.php?file=%{name}2/%{name}2-source.zip

BuildRequires:  unzip
BuildRequires:  /usr/bin/convert
Requires:       love >= 0.7.2

%description
Not Tetris 2 is the spiritual successor of the classic Tetris mixed with
physics. The result is a fun spin off in which blocks are no longer bound to
the usual grid. Blocks can be rotated and placed at any angle, resulting in a
complete mess if not careful. And with the newest cutting edge technology, Not
Tetris 2 allows line clears when the lines are sufficiently filled. The old
mode is still available for play and is now called Stack.

%description -l es
Not Tetris 2 es el sucesor espiritual del Tetris clásico mezclado con física.
El resultado es un juego divertido en el cual los bloques ya no están limitados
a moverse por la típica rejilla. Los bloques se pueden rotar y colocar en
cualquier ángulo, lo que resulta en un lío tremendo si no se lleva cuidado.
Con la última tecnología, Not Tetris 2 permite que las líneas se vacíen cuando
están suficientemente completas. El antiguo modo todavía está disponible para
jugar, y ahora se llama "Stack".

%prep
%setup -qc

# Remove Windows EOLs
sed -i 's/\r$//' *.txt

# Rename files
mv 'Not Readme.txt' readme.txt
mv 'Not Tetris 2.love' %name.love

# Create executable
echo -e "#!/bin/sh\nlove %_datadir/%name/%name.love\n" > %name

# Create desktop launcher
echo "[Desktop Entry]
Type=Application
Version=1.0
Encoding=UTF-8
Name=Not Tetris 2
Comment=Classic Tetris mixed with physics
Comment[es]=Tetris clásico mezclado con física
Icon=%_icons96dir/%name.png
Exec=%name
Terminal=false
StartupNotify=true
Categories=Application;Game;ArcadeGame;
" > %name.desktop

# Create app icon
unzip -p %name.love graphics/title.png | convert - -geometry 96x96 %name.png


%install
install -pDm u=rw,go=r %name.love %buildroot%_datadir/%name/%name.love
install -pDm u=rwx,go=rx %name %buildroot%_bindir/%name
install -pDm u=rwx,go=rx %name.desktop %buildroot%_desktopdir/%name.desktop
install -pDm u=rw,go=r %name.png %buildroot%_icons96dir/%name.png


%files
%defattr(-, root, root)
%doc readme.txt
%_bindir/%name
%_datadir/%name/%name.love
%_desktopdir/%name.desktop
%_icons96dir/%name.png


%changelog
* Fri Dec 30 2011 Yajo <yajodj at msn.com> 2.0-1
- Initial release

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.