[Bug 2237] Homer - live conferencing and more

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2237

Alec Leamas <leamas.alec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |leamas.alec at gmail.com

--- Comment #1 from Alec Leamas <leamas.alec at gmail.com> 2012-03-21 19:50:24 CET ---
Welcome onboard!

In the following, there will be a lot of complaints... it's actually supposed
to be encouraging :) Furthermore, these are just some initial comments, not a
review. Hopefully it'll help you down the road, though.

The rpmlint stuff:

Homer.src: W: name-repeated-in-summary C Homer
You could (and should) fix this by rephrasing the summary (which we already
know it applies to Homer)

Homer.src:64: W: macro-in-comment %setup
Fix by using %%

Homer.src:14: W: mixed-use-of-spaces-and-tabs (spaces: line 14, tab: line 1)
Just fix it, using your editor or e. g., expand(1)

Homer.src: W: invalid-url Source0: Homer-Source.tar.bz2
Since this is released code, it could retrieved using the sourceforge URL See
http://fedoraproject.org/wiki/Packaging:SourceURL#Sourceforge.net

Homer-debuginfo.x86_64: E: debuginfo-without-sources
You must fix this. The cause is probably that the source is stripped by the
standard make. Most likely, this error will disappear when you fix the
compiler flags according to
http://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags. I'm not
sure, but out of the top of my head cmake honors the classical CFLAGS/CPPFLAGS
environment variables, which should make it reasonably easy to fix this.

libHomer.x86_64: E: invalid-soname /usr/lib64/libHomerConference.so
These are trickier. Basically, rmplint complains because homer installs
libraries among the public libraries without proper so-names. I'm somewhat
worried about this, especially for libHomer.so. Does it need to be versioned?
Anyone, out there?

libHomer.x86_64: E: incorrect-fsf-address /usr/share/doc/libHomer-0.22/COPYING
For this, you should send a bug ticket upstream, and bring that link in this
bug. However, don't patch the file (legal concerns. Sorry, don't find the
link).

Other remarks:
Since you use desktop-file-install, the desktop-file-validate is not needed and
can be removed

IMHO it would be good to decrease the noise by removing comments such as
"Add .desktop file".

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.