[Bug 2205] Review request: sox-plugins-freeworld

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2205

--- Comment #7 from Richard <hobbes1069 at gmail.com> 2012-03-22 01:51:00 CET ---
(In reply to comment #5)
> Some initial remarks:
> No license break-down  
> (http://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Multiple_Licensing_Scenarios)

I used licensecheck on it and all I saw was LGPLv2... Is there other licenses
involved?


> Contains bundled libgsm (~fedora package gsm-devel). Package seems to link
> to system libgsm, but the bundled lib is not removed in %prep as required
> in http://fedoraproject.org/wiki/Packaging:Treatment_Of_Bundled_Libraries.

Removed in %prep now.


> Contains bundled lpc10. lpc10 seems to be part of spandsp-devel. This might
> mean that this could be used to provide lpc10. It might also mean that a
> bundling bug should be filed against spandsp-devel instead, while packaging
> lpc10 separately (which at least Mandriva do).

I'm using spandsp-devel now and removing in %prep. If a bug needs to be filed
against spandsp then we can do that but as far as I'm concerned this package is
"fixed" :)


> Is the realname macro useful? I doubt the package name will ever change,
> and it's only expanded in one place anyway.

I'm only using it because I'm really building sox since the
sox-plugins-freeworld name is made up.


> For some reason, the build fails on my F16 host. Another, F15, works fine as do
> mock. Something is rotten here, I'll try to find out what.
> 
> I have 
> %__arch_install_post /usr/lib/rpm/check-rpaths /usr/lib/rpm/check-buildroot
> in my .rpmmacros. This triggers the following in build, after %install:
> ERROR   0002: file '/usr/lib64/sox/libsox_fmt_mp3.so' contains an invalid rpath
> ~/rpmbuild/BUILD/sox-14.3.2/src/.libs' which is discouraging.

Hmm... I thought I had the rpath issue fixed...

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.