[Bug 2140] bombono-dvd - DVD authoring program with nice and clean GUI

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2140

--- Comment #47 from Jeremy Newton <alexjnewt at hotmail.com> 2012-03-31 19:04:59 CEST ---
Okay I managed to build it, so I'll continue with my review

[+] rpmlint output:
The only warning is nothing to worry about
[-] package meets the packaging guidelines
-I still think %{?rel_tag} should be in release, please see comment#46,
obviously this is still under discussion.
-Requires(post) and (postun) should be removed
-There seems to be some explicit require issues, see my comments below
=The date should be changed on a git snapshot only when the source is re-pulled
from git, else wise the release number should be increased. This isn't a big
deal but I just thought I would mention it for future modifications. :)
[-] spec file is legible
- I still think it would help to say something like "##Commands to grab from
git" above the source grab commands, but this obviously still a work in
progress
[-] sources match upstream: md5sum do not match
- Still a work in progress
[+] package builds on at least one primary arch: x86-64 builds just fine

SHOULD:
[?] package builds in mock: I never tested due to the ASL reasons in comment#38
[?] package builds on all supported arches: I never tested
[+] package functions as described:
Application runs and I see no issues.
[+] sane scriptlets

A few comments:

I bumped up the karma on ASL release 8, though I still could not test mock as
it hasn't been pulled into stable yet. I don't need to test it in mock for this
to be accepted but I would heavily advise you to do so before uploading it via
CVS as it may help to avoid failed builds.

Also, I noticed you explicitly required 5 packages. Explicit requires are only
needed if they are not needed or are picked up by RPMBUILD or a requirement of
one of those picked by RPMBuild. Please double check these! :)
For example, ffmpeg is one of these 5, yet libavcodec.so.53 and
libavformat.so.53 are picked up by Rpmbuild and are a part of ffmpeg. As well
mjpegtools also requires ffmpeg, so ffmpeg should definitely be removed under
requires. Please see the guidelines if you need a more in depth explanation:
http://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires

Good job so far though :)

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.