[Bug 2472] Review request: gstreamer1-libav - GStreamer 1.0 FFmpeg-based plug-ins

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2472

Andrea Musuruane <musuruan at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|3                           |4

--- Comment #14 from Andrea Musuruane <musuruan at gmail.com> 2012-11-03 10:30:10 CET ---
(In reply to comment #13)
> > As you can see the first part is composed by the standard Fedora optflags. In
> > the second part there are other flags. One in particular caught my attention:
> > the "-O3" that overrides the "-O2". This is not permitted by Fedora Guidelines. 
> > 
> 
> This is only the case for the included / bundled libav copy, not for the actual
> gstreamer code. And I just double checked and rpmfusion's own ffmpeg packages
> are build the same way. I guess this is a case of upstream knows best, as this
> is quite performance sensitive code and upstream seems to go through
> a great deal of trouble to get certain cflags passed and explictly disables
> some problematic optimizations.
> 
> If you really believe this is an issue.  I belief the proper way forward with
> this
> is to file a bug against the ffmpeg package, and if / when that gets fixed
> I'll duplicate the fix in the gstreamer-ffmpeg and gstreamer1-libav packages,
> in the mean time I would like to move forward with this review though.

I just opened bug #2560. Please add to the specfile that you are using the same
flags used by the ffmpeg package as required by the Fedora Packaging
guidelines:
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Compiler_flags

When ffmpeg maintainer will fix this issue, you need to act accordingly.

APPROVED!

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.