[Bug 2455] Review request: pcsx2 - A Sony Playstation2 emulator

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2455

--- Comment #5 from Giles Birchley <gbirchley at blueyonder.co.uk> 2012-09-02 18:01:24 CEST ---
Hi Andrea,

Sorry to take so long to respond - I'm afraid this will get done in spits and
spots - but I guess you are busy too.

I'm having a go at responding to your ideas, but I'm having problems with the
build when I remove the specified cflags. I have patched BuildParameters.cmake
to remove the offending flags;

--- pcsx2-1.0/cmake/BuildParameters.cmake
+++ pcsx2-1.0/cmake/BuildParameters.cmake
@@ -125,7 +125,7 @@
 # Set some default compiler flags

#-------------------------------------------------------------------------------
 set(DEFAULT_WARNINGS "-Wno-write-strings -Wno-format -Wno-unused-parameter
-Wno-unused-value -Wstrict-aliasing -Wno-unused-function")
-set(DEFAULT_GCC_FLAG "-m32 -msse -msse2 -march=i686 -pthread
${DEFAULT_WARNINGS}")
+set(DEFAULT_GCC_FLAG "-pthread ${DEFAULT_WARNINGS}")
 set(DEFAULT_CPP_FLAG "${DEFAULT_GCC_FLAG} -Wno-invalid-offsetof")


#-------------------------------------------------------------------------------




but the SSE flag seems to be not passed to cmake:

[ 12%] Building CXX object plugins/GSdx/CMakeFiles/GSdx-0.1.16.dir/GPU.cpp.o
cd /home/makerpm/rpmbuild/BUILD/pcsx2-1.0/plugins/GSdx && /usr/lib/ccache/c++  
-DGSdx_0_1_16_EXPORTS -DPLUGIN_DIR_COMPILATION=/usr/lib/pcsx2
-DGAMEINDEX_DIR_COMPILATION=/usr/share/pcsx2
-DGLSL_SHADER_DIR_COMPILATION=/usr/lib/pcsx2 -D_FILE_OFFSET_BITS=64
-D_LARGE_FILES -D__WXGTK__ -DOGL_MT_HACK -D_LINUX -DNDEBUG -O2 -g -pipe -Wall
-Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
--param=ssp-buffer-size=4  -m32 -march=i686 -mtune=atom
-fasynchronous-unwind-tables  -pthread -Wno-write-strings -Wno-format
-Wno-unused-parameter -Wno-unused-value -Wstrict-aliasing -Wno-unused-function
-Wno-invalid-offsetof -pthread -I/usr/include/gdk-pixbuf-2.0
-I/usr/include/freetype2 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include
-I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/cairo
-I/usr/include/pango-1.0 -I/usr/include/atk-1.0 -I/usr/include/SDL -isystem
/usr/lib/wx/include/gtk2-unicode-release-2.8 -isystem /usr/include/wx-2.8
-I/home/makerpm/rpmbuild/BUILD/pcsx2-1.0/common/include
-I/home/makerpm/rpmbuild/BUILD/pcsx2-1.0/common/include/Utilities
-I/home/makerpm/rpmbuild/BUILD/pcsx2-1.0/common/include/x86emitter
-I/usr/include/i386-linux-gnu -I/usr/include/x86_64-linux-gnu
-I/home/makerpm/rpmbuild/BUILD/pcsx2-1.0/plugins/GSdx/.    -fno-operator-names
-mpreferred-stack-boundary=2 -mfpmath=sse -Wunused-variable -std=c++0x
-fno-strict-aliasing -O2 -W -o CMakeFiles/GSdx-0.1.16.dir/GPU.cpp.o -c
/home/makerpm/rpmbuild/BUILD/pcsx2-1.0/plugins/GSdx/GPU.cpp
/home/makerpm/rpmbuild/BUILD/pcsx2-1.0/plugins/GSdx/GPU.cpp:1:0: warning: SSE
instruction set disabled, using 387 arithmetics [enabled by default]
In file included from
/home/makerpm/rpmbuild/BUILD/pcsx2-1.0/plugins/GSdx/stdafx.h:296:0,
                 from
/home/makerpm/rpmbuild/BUILD/pcsx2-1.0/plugins/GSdx/GPU.cpp:22:
/usr/lib/gcc/i686-redhat-linux/4.6.3/include/xmmintrin.h:32:3: error: #error
"SSE instruction set not enabled"




is there some way around this problem? I am calling cmake in the spec with:

%cmake . -DPACKAGE_MODE=TRUE -DGLSL_SHADER_DIR=%{_libdir}/%{name}
-DBUILD_REPLAY_LOADERS=TRUE -DXDG_STD=FALSE -DGLSL_API=FALSE
-DCMAKE_INSTALL_PREFIX="/usr" -DPLUGIN_DIR=%{_libdir}/%{name}
-DGAMEINDEX_DIR=%{_datadir}/%{name} -DFORCE_INTERNAL_SOUNDTOUCH=FALSE
-DFORCE_INTERNAL_SDL=FALSE -DCMAKE_BUILD_TYPE=Release
-DCMAKE_VERBOSE_MAKEFILE=TRUE
make %{?_smp_mflags} VERBOSE=1

Another comment - you ask that I specify the build type as Debug and report the
errors from rpmlint - I assume this is not for the final build? Debug build of
pcsx2 runs very slowly compared to Release.

Full pcsx2 licensing information is at the following url:
http://code.google.com/p/pcsx2/source/browse/branches/1.0/debian-unstable-upstream/copyright
You are right that LGPLv3+ is the correct license, sorry ...

I am downloading from svn specifying a revision because the format of the
create_pcsx2_tarball.sh script needs a revision as well a branch. As the branch
is 1.0, the revision is immaterial. I can change the script so it doesn't
specify a revision if this is more acceptable. The script also does not
download the 3rd party libraries AFAIK.

I have addressed other small things, but documents and languages are still
parked for this week!

Although it is a WIP I have uploaded the new spec to:
http://forums.pcsx2.net/attachment.php?aid=40016

I do appreciate your advice, thank-you.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.