[Bug 2455] Review request: pcsx2 - A Sony Playstation2 emulator

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2455

--- Comment #12 from Giles Birchley <gbirchley at blueyonder.co.uk> 2012-09-09 17:41:10 CEST ---
Hi Andrea and Richard, I have moved the spec file forward I think, and now the
documents and the localizations are improved.

I have not yet tried rpmlint or to report any errors upstream, but using
-DCMAKE_BUILD_TYPE=RelWithDebInfo results in a big debugging package (28 MB)
and builds okay - so thanks for that tip, Richard. I have removed the changes
you made for the out of source build as I could not build with them - and while
I see the point of not polluting source if I am using the development build, it
seems to make no difference when packaging as far as I can see.

So I think the problems left are these:
-detecting sse2
-using the svn as a source rather than the pcsx2 download webpage
-report debug errors in rpmlint upstream

-detecting sse2:
I think the outcome of the online discussion on the list was that I should
include a check for SSE2 in the spec file, so it would not build if not present
on the machine?
My programming is not very good. I can check for sse with cat /proc/cpuinfo -
could I then egrep -q 'sse2'  
This doesn't seem to work for me: I would be grateful if you could suggest a
way to check for sse2 and stop the build if not present?

-using the source on csx2 webpage:
the source on pcsx2 webpage 
<http://pcsx2.net/download/releases/source-code/summary/7-source/93-pcsx2-v1-0-0-source-code.html>
requires that a box is checked to agree to conditions then a html button is
clicked to start download. The download is a 7zip file of the entire trunk
(i.e. 3rd party and useless windows libraries etc etc.). This seems very
complicated to me- I do not know the method to get a file in bash when the page
requests this information. Also, I can modify Gregory's script to create a
tarball from this file, but this script will then depend on 7zip. Is this
preferable to the current method - (svn branch 1.0 is stable)? If so, is it
possible can you suggest how I can download the source from this page?

-I will deal with rpmlint error reporting after these issues are resolved.

spec file: <http://forums.pcsx2.net/attachment.php?aid=40093>
srpm: <http://forums.pcsx2.net/attachment.php?aid=40094>

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.