[Bug 2455] Review request: pcsx2 - A Sony Playstation2 emulator

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2455

--- Comment #21 from gregory.hainaut at gmail.com 2012-09-10 15:21:23 CEST ---
>> The easiest way is to do as Richard said (just one parameter in cmake)
For me it is not valid, it doesn't do what you think.

Here an extract of PCSX2's cmake file:

#-------------------------------------------------------------------------------
# if no build type is set, use Devel as default
# Note without the CMAKE_BUILD_TYPE options the value is still defined to ""
# Ensure that the value set by the User is correct to avoid some bad behavior
later
#-------------------------------------------------------------------------------
if(NOT CMAKE_BUILD_TYPE MATCHES "Debug|Devel|Release")
    set(CMAKE_BUILD_TYPE Devel)
    message(STATUS "BuildType set to ${CMAKE_BUILD_TYPE} by default")
endif(NOT CMAKE_BUILD_TYPE MATCHES "Debug|Devel|Release")

if(NOT DEFINED CMAKE_BUILD_STRIP)
    if(CMAKE_BUILD_TYPE STREQUAL "Release")
        set(CMAKE_BUILD_STRIP TRUE)
        message(STATUS "Enable the stripping by default in ${CMAKE_BUILD_TYPE}
build !!!")
    else(CMAKE_BUILD_TYPE STREQUAL "Release")
        set(CMAKE_BUILD_STRIP FALSE)
        message(STATUS "Disable the stripping by default in ${CMAKE_BUILD_TYPE}
build !!!")
    endif(CMAKE_BUILD_TYPE STREQUAL "Release")
endif(NOT DEFINED CMAKE_BUILD_STRIP)



For the parameter you can drop -m32 (only useful on 64 bits machine anyway) no
impact. I'm not sure i686 is important but is there any sse2 cpu that doesn't
support i686 instruction set? PCSX2 requires a powerful PC it won't run on 10
years old PC anyway. Checked i686 is 1995 so 17 years old! It is older than the
PS2 ;)


As upstream I will try to post somewhere a tar gz.

Cheers

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.