[Bug 2455] Review request: pcsx2 - A Sony Playstation2 emulator

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2455

--- Comment #51 from Andrea Musuruane <musuruan at gmail.com> 2013-06-24 17:39:56 CEST ---
(In reply to comment #47)
> Hi, many thanks for patiently waiting.
> 
> As Gregory from upstream has alerted, PCSX2 now has a 1.1 release that contains
> many Linux fixes. I have therefore updated the spec file to package this
> version. Hopefully everyone will be happy with this. 

Good!

> I have solved most of the rpmlint errors, but am still stumped on the
> script-without-shebang on the xpm icon file, my sed command doesn't seem to
> have helped. I guess this could be fixed by slicing the gordian knot and making
> this file anew as a png or something instead of using the one that comes with
> package. I'd be grateful for advice on this one.

Sed is not useful because there is no shebang in the xpm file.

I also can't understand the two sed command you already use on the xpm file.

But it has an executable bit set:
$ rpm -qplv pcsx2-1.1.0-1.fc20.i686.rpm
[...]
-rwxr-xr-x    1 root    root                    62834 Jun 24 16:56
/usr/share/icons/hicolor/128x128/apps/pcsx2.xpm
[...]

This is your fault because you are setting it here:
install -pm 755 %{_builddir}/%{name}.snapshot-5674/linux_various/pcsx2.xpm
%{buildroot}/%{_datadir}/icons/hicolor/128x128/apps/

Just replace 755 with 644.

> The url error has me a little bit stumped as I'm not sure whether I should be
> including the whole ugly:
> http://code.google.com/p/pcsx2/downloads/detail?name=pcsx2-1.1.0-r5674-lnx-sources.tar.bz2&can=2&q=
> as the url location. Again, advice would be great.

The one you picked is an HTML page and not the upstream source file.

The following one works for me:
https://pcsx2.googlecode.com/files/pcsx2-1.1.0-r5674-lnx-sources.tar.bz2

> I assume everyone's happy to let go the description-line-too-long error.

Actually I'm not happy. Each line should not exceed 80 characters. So break the
description into multiple lines.

* The URL tag is still wrong. You are linking the download page and not the
main site page. Either http://pcsx2.net/ or https://code.google.com/p/pcsx2/

* You have removed the %{version} macro in patches - this is fine. It was
convenient to have it in Source0 though. Otherwise you have to change it in
more than one place at the next release.

* The backslash there is at the end of the last line of the %cmake command is
wrong - you are safe only because there is an empty line next.

* Use the same indentation even when you are using spaces. Until the Patch1 tag
you indent the lines in a way, then you change in another format. Choose one
(the one you like best) and stick with it.

* I also noticed that using -DDOC_DIR doesn't seem to have any effect when
installing files. In fact I still see them installed in /usr/share/doc/pcsx2/
instead of /usr/share/doc/pcsx2-1.1.0/. You can drop it from %cmake if it
doesn't work.

* Are you sure these are useful?
#remove readme-Docs.text as this is for developers not end users
rm -rf %{buildroot}/Docs/readme-Docs.txt
#remove bin/docs/GPL.html as there is already a GPL.txt file
rm -rf %{buildroot}/bin/docs/GPL.html

I can't see anything installed there.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.