[Bug 2237] Homer - live conferencing and more

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2237

Richard <hobbes1069 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hobbes1069 at gmail.com

--- Comment #28 from Richard <hobbes1069 at gmail.com> 2013-03-01 20:09:56 CET ---
One small fix is needed in your %files section. 

Falling under the rule[1]:
MUST: A package must own all directories that it creates. If it does not create
a directory that it uses, then it should require a package which does create
that directory. 

You need to make sure the package owns "%{_datadir}/%{name}" and all of the
files and directories under it. Although using just "%{_datadir}/%{name}" would
accomplish this, it also hides the files you're packaging so I would suggest
something like:

%dir %{_datadir}/%{name}
%{_datadir}/%{name}/%{name}.png
%{_datadir}/%{name}/lang/

Besides adding the %dir tag, I also removed the "*" from the lang line, this is
because if you leave the "*", then the package will only own the files in the
lang directory and not the directory itself. Dropping the "*" means the package
will own the lang directory and anything in it.

This makes sure that if upstream adds files to the %{_datadir}/%{name}
directory that the build fails which forces you to take a look and see if
something is wrong, or maybe you need to update the %files section. 

The trailing "/" is not technically required, but it lets other packagers or
potential reviewers that your specifying a directory and not a file.

[1]
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#FileAndDirectoryOwnership

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.