Mass rebuilt for F-19 on RPM Fusion - next week

[Hans de Goede]

Hi,

On 03/24/2013 07:46 PM, Andrea Musuruane wrote:
> On Tue, Mar 12, 2013 at 7:43 PM, Andrea Musuruane <musuruan at gmail.com <mailto:musuruan at gmail.com>> wrote:
>
>     On Tue, Mar 12, 2013 at 6:15 PM, Sérgio Basto <sergio at serjux.com <mailto:sergio at serjux.com>> wrote:
>
>         better late then never , the fails are:
>         16390   zsnes   zsnes-1_51-13_fc19
>
>
>     I found this patch made by Debian to fix this issue:
>     http://patch-tracker.debian.org/patch/series/view/zsnes/1.510+bz2-5/0012-Fix-build-with-gcc-4.7.patch
>
>     I'll apply it soon.
>
>
> I tried to fix this issue but I hit another. Now when I build with mock I get the following error:
>
> [...]
> g++ -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4  -m32 -march=i686 -mtune=atom -fasynchronous-unwind-tables -I. -D__UNIXSDL__  -I/usr/include/SDL -D_GNU_SOURCE=1 -D_REENTRANT  -D__LIBAO__ -D__OPENGL__ -march=i386 -D__RELEASE__ -fno-rtti -o tools/depbuild tools/depbuild.cpp tools/fileutil.o tools/strutil.o
> tools/depbuild.cpp: In function 'int main(int, const char* const*)':
> tools/depbuild.cpp:214:30: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
> tools/depbuild.cpp: In function 'void dependency_calculate_asm(const char*)':
> tools/depbuild.cpp:135:26: warning: ignoring return value of 'int system(const char*)', declared with attribute warn_unused_result [-Wunused-result]
> /tmp/ccTlkeDY.o: In function `__exchange_and_add':
> /usr/lib/gcc/i686-redhat-linux/4.7.2/../../../../include/c++/4.7.2/ext/atomicity.h:48: undefined reference to `__atomic_fetch_add_4'
> tools/strutil.o: In function `__exchange_and_add':
> /usr/lib/gcc/i686-redhat-linux/4.7.2/../../../../include/c++/4.7.2/ext/atomicity.h:48: undefined reference to `__atomic_fetch_add_4'
> /usr/lib/gcc/i686-redhat-linux/4.7.2/../../../../include/c++/4.7.2/ext/atomicity.h:48: undefined reference to `__atomic_fetch_add_4'
> collect2: error: ld returned 1 exit status
> make: *** [tools/depbuild] Error 1
> errore: Stato d'uscita errato da /var/tmp/rpm-tmp.m63Y3l (%build)
> Errori di compilazione RPM:
>      Stato d'uscita errato da /var/tmp/rpm-tmp.m63Y3l (%build)
> Child return code was: 1
> EXCEPTION: Command failed. See logs for output.
>   # ['bash', '--login', '-c', 'rpmbuild -bb --target i686 --nodeps builddir/build/SPECS/zsnes.spec']
> Traceback (most recent call last):
>    File "/usr/lib/python2.7/site-packages/mockbuild/trace_decorator.py", line 70, in trace
>      result = func(*args, **kw)
>    File "/usr/lib/python2.7/site-packages/mockbuild/util.py", line 359, in do
>      raise mockbuild.exception.Error, ("Command failed. See logs for output.\n # %s" % (command,), child.returncode)
> Error: Command failed. See logs for output.
>   # ['bash', '--login', '-c', 'rpmbuild -bb --target i686 --nodeps builddir/build/SPECS/zsnes.spec']
> LEAVE do --> EXCEPTION RAISED
>
> I can't understand the cause.
>
> The SRPM is here:
> https://dl.dropbox.com/u/12575912/zsnes-1.51-14.fc17.src.rpm
>
> Does someone has a spare cycle?

Just threw a few spare cycles at this, the error you were seeing was caused by
passing "force_arch=i386" to configure, changing this to "force_arch=i686"
fixed that error.

Then I hit a crash on startup due to zsnes feeding a (partly) uninitialized
struct to libao, fixed that too.

I also cleaned up the specfile a bit:
-drop obsolete buildroot stuff
-use up2date gtk-icon-cache scriptlets
-don't pass --vendor to desktop-file-install on F-19+

I've commit all this to CVS for F19+ and started builds, chances are the
rawhide build will fail due to hitting a mirror sync window. If this happens
I'll requeue it tomorrow.

Regards,

Hans