[Bug 2909] Review request: gtkradiant - Level design program for video games

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2909

--- Comment #5 from Alberto <bebo.sudo at gmail.com> 2013-11-01 00:54:10 CET ---
Hi!

SRPM:
http://sourceforge.net/projects/bebosudo-rpms/files/gtkradiant/F19/SRPMS/gtkradiant-1.6.4-1.20131031git.fc19.src.rpm/download
SPEC:
http://sourceforge.net/projects/bebosudo-rpms/files/gtkradiant/gtkradiant.spec/download

This is a fresh build of gtkradiant with some interesting improvements.
Here an extract trom the spec:

- added gtkradiant manual from the official website
- added LGPL and BSD to license field (see LICENSE file inside doc)
- added patch to allow the use of gtkradiant also on linux, else it wouldn't
work, due to permissions errors (goo.gl/G8xPKg)
- added a script launcher to fix the gamepacks
- split data in another package 
- added libjped-turbo-devel as a buildrequire

and here the rpmlint on all the packages:
$ rpmlint -i
../RPMS/x86_64/gtkradiant-{,debuginfo-}1.6.4-1.20131030git.fc19.x86_64.rpm
../SRPMS/gtkradiant-1.6.4-1.20131030git.fc19.src.rpm gtkradiant.spec

gtkradiant.x86_64: E: incorrect-fsf-address /usr/share/doc/gtkradiant-1.6.4/GPL
The Free Software Foundation address in this file seems to be outdated or
misspelled.  Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.

gtkradiant.x86_64: E: incorrect-fsf-address
/usr/share/doc/gtkradiant-1.6.4/LGPL
The Free Software Foundation address in this file seems to be outdated or
misspelled.  Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.

gtkradiant.x86_64: W: no-manual-page-for-binary q3map2
Each executable in standard binary directories should have a man page.

gtkradiant.x86_64: W: no-manual-page-for-binary q3map2_urt
Each executable in standard binary directories should have a man page.

gtkradiant.x86_64: W: no-manual-page-for-binary gtkradiant
Each executable in standard binary directories should have a man page.

gtkradiant-debuginfo.x86_64: E: debuginfo-without-sources
This debuginfo package appears to contain debug symbols but no source files.
This is often a sign of binaries being unexpectedly stripped too early during
the build, or being compiled without compiler debug flags (which again often
is a sign of distro's default compiler flags ignored which might have security
consequences), or other compiler flags which result in rpmbuild's debuginfo
extraction not working as expected.  Verify that the binaries are not
unexpectedly stripped and that the intended compiler flags are used.

(none): E: no installed packages by name
../SRPMS/gtkradiant-1.6.4-1.20131030git.fc19.src.rpm
gtkradiant.spec: W: invalid-url Source5: gtkradiant-manual-20131030.tar.gz
The value should be a valid, public HTTP, HTTPS, or FTP URL.

2 packages and 1 specfiles checked; 3 errors, 4 warnings.


The first two depend on the upstream license version.
the third and fourth don't have a manual page because are small utilities, and
the fifth, the gtkradiant exec, has an huge manual page in the %doc, so I don't
know why rpmlint complains.
sixth I don't know what to do.
seventh is right, because the source is made manually.

I know there is a lot of work to do, but would really appreciate it if someone
was interested in helping me.

Thanks,
Alberto

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.