[Bug 3043] Review request: lfp-flash-plugin - Adobe Flash Player package bootstrap

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3043

--- Comment #9 from Simone Caronni <negativo17 at gmail.com> 2013-11-26 14:24:35 CET ---
> - Wouldn't it be possible for the x86_64 variant to include both the i386 and
> the x86_64 stuff (Nicholas remark)?. Thinking about it, the x86_64 could
> download both sources and augment the x86_64 installation with the i386 plugin.
> The only conflict I see in the filelist is flash-player-properties; the 32-bit
> variant could be installed as flash-player-properties32 in the x86_64 case if
> required. Couldn't all this be done just by updating the spec, without any lpf
> changes?

Fedora already handles such cases of duplicated binaries, the native one takes
precedence. Please look here at my system where I have both installed:

$ rpm -qa flash-plugin
flash-plugin-11.2.202.327-1.fc19.i686
flash-plugin-11.2.202.327-1.fc19.x86_64

The following lists both packages:

$ rpm -ql flash-plugin | grep bin
/usr/bin/flash-player-properties
/usr/bin/flash-player-properties

But the one in bin is the correct arch one.

$ file /usr/bin/flash-player-properties
/usr/bin/flash-player-properties: ELF 64-bit LSB executable, x86-64, version 1
(SYSV), dynamically linked (uses shared libs), for GNU/Linux 2.6.9, stripped

But more clean would be if I would split flash-player-properties in its own
package.

This way we can have the libs on both archs (i686 and x86_64) and the
flash-player-properties only in your native arch. The purpose of
flash-player-properties is to only write preferences in ~/.adobe.

This would make everything look like normal libraries in Fedora, where you have
the libs multiarch, and the binaries single arch.

x86_64:
flash-plugin-properties.x86_64
flash-plugin.x86_64
flash-plugin.i686

i686:
flash-plugin-properties.i686
flash-plugin.i686

I'm doing this, will post it the updated package in a couple of hours (I'm at
work!).

Question for Alec: can't we just run lpf-setup-pkg two times, one for each arch
in the %install section if the arch is x86_64?

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.