[Bug 2979] New: Review request: steam - Installer for the Steam software distribution service

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2979

             Bug #: 2979
           Summary: Review request: steam - Installer for the Steam
                    software distribution service
    Classification: Unclassified
           Product: Package Reviews
           Version: Current
          Platform: All
        OS/Version: GNU/Linux
            Status: NEW
          Severity: normal
          Priority: P5
         Component: Review Request
        AssignedTo: rpmfusion-package-review at rpmfusion.org
        ReportedBy: negativo17 at gmail.com
                CC: rpmfusion-package-review at rpmfusion.org
            Blocks: 2


Installer for the Steam software distribution service.
Steam is a software distribution service with an online store, automated
installation, automatic updates, achievements, SteamCloud synchronized
savegame and screenshot functionality, and many social features.

Spec URL: http://slaanesh.fedorapeople.org/steam.spec
SRPM URL: http://slaanesh.fedorapeople.org/steam-1.0.0.42-1.fc19.src.rpm

This package cannot be in Fedora as it's not free and comes as a binary package
only. The package is i686 only but installs perfectly fine on an x86_64 system
just using yum. It's in the Fedora RPMFusion wishlist.

$ rpmlint steam.spec 
steam.spec:31: W: macro-in-comment %{name}
steam.spec:32: W: macro-in-comment %{_isa}
0 packages and 1 specfiles checked; 0 errors, 2 warnings.

These macro in comments are for the command line required for generating
dependencies on Steam downloaded binaries; it is nice to have them at hand to
check for new dependencies whenever a new Steam client is automatically
downloaded.

$ rpmlint steam-1.0.0.42-1.fc19.i686.rpm 
steam.i686: E: explicit-lib-dependency libICE(x86-32)
steam.i686: E: explicit-lib-dependency libSM(x86-32)
steam.i686: E: explicit-lib-dependency libX11(x86-32)
steam.i686: E: explicit-lib-dependency libXau(x86-32)
steam.i686: E: explicit-lib-dependency libXcomposite(x86-32)
steam.i686: E: explicit-lib-dependency libXcursor(x86-32)
steam.i686: E: explicit-lib-dependency libXdamage(x86-32)
steam.i686: E: explicit-lib-dependency libXdmcp(x86-32)
steam.i686: E: explicit-lib-dependency libXext(x86-32)
steam.i686: E: explicit-lib-dependency libXfixes(x86-32)
steam.i686: E: explicit-lib-dependency libXi(x86-32)
steam.i686: E: explicit-lib-dependency libXinerama(x86-32)
steam.i686: E: explicit-lib-dependency libXrandr(x86-32)
steam.i686: E: explicit-lib-dependency libXrender(x86-32)
steam.i686: E: explicit-lib-dependency libXtst(x86-32)
steam.i686: E: explicit-lib-dependency libasyncns(x86-32)
steam.i686: E: explicit-lib-dependency libattr(x86-32)
steam.i686: E: explicit-lib-dependency libcap(x86-32)
steam.i686: E: explicit-lib-dependency libcom_err(x86-32)
steam.i686: E: explicit-lib-dependency libdrm(x86-32)
steam.i686: E: explicit-lib-dependency libffi(x86-32)
steam.i686: E: explicit-lib-dependency libgcc(x86-32)
steam.i686: E: explicit-lib-dependency libgcrypt(x86-32)
steam.i686: E: explicit-lib-dependency libgpg-error(x86-32)
steam.i686: E: explicit-lib-dependency libgudev1(x86-32)
steam.i686: E: explicit-lib-dependency libogg(x86-32)
steam.i686: E: explicit-lib-dependency libpng12(x86-32)
steam.i686: E: explicit-lib-dependency libselinux(x86-32)
steam.i686: E: explicit-lib-dependency libsndfile(x86-32)
steam.i686: E: explicit-lib-dependency libstdc++(x86-32)
steam.i686: E: explicit-lib-dependency libusbx(x86-32)
steam.i686: E: explicit-lib-dependency libuuid(x86-32)
steam.i686: E: explicit-lib-dependency libvorbis(x86-32)
steam.i686: E: explicit-lib-dependency libwayland-client(x86-32)
steam.i686: E: explicit-lib-dependency libwayland-server(x86-32)
steam.i686: E: explicit-lib-dependency libxcb(x86-32)
steam.i686: W: name-repeated-in-summary C steam
steam.i686: W: spelling-error %description -l en_US savegame -> save game,
save-game, pregame
steam.i686: W: spelling-error %description -l en_US screenshot -> screen shot,
screen-shot, screens hot
steam.i686: W: invalid-license Steam License Agreement
steam.i686: E: no-binary
steam.i686: W: only-non-binary-in-usr-lib
steam.i686: W: wrong-file-end-of-line-encoding
/usr/share/doc/steam-1.0.0.42/steam_install_agreement.txt
steam.i686: W: desktopfile-without-binary /usr/share/applications/steam.desktop
/usr/bin/steam
1 packages and 0 specfiles checked; 37 errors, 7 warnings.

Notes on rpmlint on the binary package: the explicit-lib-dependency can be
ignored; these are the dependencies used by the Steam client itself, and need
to be on the system BEFORE the actual Steam client is downloaded. The package
itself contains only a script; so the last errors are related to the fact that
the desktop files etc. point to a script and not a binary.

The package sets STEAM_RUNTIME=0 in /etc/profile.d/steam.*; so the download
client and the Steam client itself do NOT use Ubuntu libraries (the Steam
runtime) for running; but instead use the Fedora system provided ones.

For additional details on the setup please see here:

http://negativo17.org/steam/

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.