[Bug 118] Review Request: cinelerra-cv - Advanced audio and video capturing, compositing, and editing

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=118

--- Comment #38 from Sérgio Basto <sergio at serjux.com> 2014-04-28 20:49:29 CEST ---
(In reply to comment #37)
> You should drop a file in /etc/sysctl.d instead to tweaking /etc/sysctl.conf
> Please drop theses coward comments (-d libswscale), packager using that was
> nuts.

Done

> gcc-g++ is an implicit default BR, please remove.

Done 

> 
> Last time I've check cinelerra was bundling msttcore-fonts from Microsoft (that
> are not redistributable). We should be able not to depends on theses,
> unfortunately it will possibly hard to convince upstream to merge this change.

patch font , have 2 things one is remove bundling msttcore-fonts from
Microsoft, other is very ugly , and don't know (yet) what is the propose 

> 
> Also which version of ffmpeg is used if it can use the shared version at all ?

For now package use internal ffmpeg ...

> Does the asm options relates to cinelerra itslef or passed to builtin ffmpeg ?
No idea 

> I'm not sure we can allow 3dnow at all in generic build ? There is a need to
> verify either it's a runtime or buildtime option.
No idea , should be (like in yours .spec) ? :   

%ifarch i686 x86_64
    --enable-mmx \
%else
    --disable-mmx \
    --disable-3dnow \
%endif

> Altivec is safe on powerpc since we should only worry of ppc64 nowadays.
No idea , what are you suggesting ? 

we have
%ifarch ppc ppc64
  --enable-altivec \
%else
  --disable-altivec \
%endif


> You should avoid to redistribute files provided by libmpeg3
> the best way was to rename them with a cinelerra-cv suffix if possible.
> At least devel files shouldn't conflicts also.
> Another way would be to drop the libmpeg3 package at all (nothing use it
> beyound cinelerra-cv anyway).

I read that patches  I am adapting to new sources

Well I see I have many good stuff in yours .spec, I will try finish other spec
for review ... next holiday.
External ffmpeg will be a good challenge  , I will try upstream some patches
like no_ms_fonts and libmpeg3_system.patch

Best regards,

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.