[Bug 3345] Review request: kodi - Media center

RPM Fusion Bugzilla noreply at rpmfusion.org
Mon Dec 29 16:14:18 CET 2014


https://bugzilla.rpmfusion.org/show_bug.cgi?id=3345

--- Comment #21 from Michael Cronenworth <mike at cchtml.com> 2014-12-29 16:14:18 CET ---
(In reply to comment #17)
> You can do something like:
> 
> find path/to/bundled/dep -name "*.c" -exec rm -f {} \;
> find path/to/bundled/dep -name "*.h" -exec rm -f {} \;
> 
> in %prep to nuke the source files but leave the autocrap.  This shouldn't break
> the build, but it will leave the reviewer confident that these bundled
> libraries are not used. :-)

That will not work because the source is downloaded during the build if the
library is not found. The code I was referring to is code that is not even
built (Android, Win32 files).

The reviewer should be performing a test build (normally a scratch build in
Fedora reviews) to verify what is and is not built.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


More information about the rpmfusion-developers mailing list