[Bug 3151] Review request: Notion - A tabbed, tiling window manager forked from Ion3
RPM Fusion Bugzilla
noreply at rpmfusion.org
Fri Jun 27 01:22:20 CEST 2014
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3151
--- Comment #2 from jeff.backus at gmail.com 2014-06-27 01:22:20 CEST ---
New version available. Also modified spec to not generate the -doc package, as
it is not really supported by upstream.
New links:
Spec URL: http://jsbackus.fedorapeople.org/notion/notion.spec
SRPM URL:
http://jsbackus.fedorapeople.org/notion/notion-3.2014052800-1.fc20.src.rpm
Koji Builds:
F19: http://koji.fedoraproject.org/koji/taskinfo?taskID=7081372
F20: http://koji.fedoraproject.org/koji/taskinfo?taskID=7081374
F21: http://koji.fedoraproject.org/koji/taskinfo?taskID=7081376
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
===== MUST items =====
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
.so files are in /usr/lib64/notion/mod/ and not in LD path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[!]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
RH Legal has confirmed that the modified LGPL v2.1 license is to
restrictive for use in official repos, and thus "nonfree".
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"LGPL (v2.1 or later) (with incorrect FSF address)", "Unknown or
generated", "MIT/X11 (BSD like)", "*No copyright* LGPL (with incorrect
FSF address)", "LGPL (with incorrect FSF address)", "LGPL (v2.1 or
later)", "*No copyright* LGPL (v2.1 or later)". 288 files have unknown
license. Detailed output of licensecheck in
/mnt/storage/backed_up/home/jeff/depot/notion/pkg/tmp/review/review-
notion/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
Permissible within constraints of "nonfree" license.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 81920 bytes in 5 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or desktop-
file-validate if there is such a file.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
Contains LICENSE from upstream in tarball.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in notion-
contrib
notion-contrib is noarch.
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package is
arched.
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: notion-3.2014052800-1.fc20.x86_64.rpm
notion-contrib-3.2014052800-1.fc20.noarch.rpm
notion-3.2014052800-1.fc20.src.rpm
notion.x86_64: W: invalid-license Redistributable, modified LGPLv2.1
notion.src: W: invalid-license Redistributable, modified LGPLv2.1
3 packages and 0 specfiles checked; 0 errors, 2 warnings.
Rpmlint (installed packages)
----------------------------
# rpmlint notion notion-contrib
notion.x86_64: W: invalid-license Redistributable, modified LGPLv2.1
2 packages and 0 specfiles checked; 0 errors, 1 warnings.
# echo 'rpmlint-done:'
Requires
--------
notion (rpmlib, GLIBC filtered):
/bin/sh
config(notion)
libICE.so.6()(64bit)
libSM.so.6()(64bit)
libX11.so.6()(64bit)
libXext.so.6()(64bit)
libXinerama.so.1()(64bit)
libXrandr.so.2()(64bit)
libc.so.6()(64bit)
libdl.so.2()(64bit)
liblua-5.2.so()(64bit)
libm.so.6()(64bit)
librt.so.1()(64bit)
rtld(GNU_HASH)
xorg-x11-fonts-ISO8859-1-75dpi
xorg-x11-utils
xterm
notion-contrib (rpmlib, GLIBC filtered):
notion
terminus-fonts
Provides
--------
notion:
config(notion)
notion
notion(x86-64)
notion-contrib:
notion-contrib
Unversioned so-files
--------------------
notion: /usr/lib64/notion/mod/de.so
notion: /usr/lib64/notion/mod/mod_dock.so
notion: /usr/lib64/notion/mod/mod_menu.so
notion: /usr/lib64/notion/mod/mod_notionflux.so
notion: /usr/lib64/notion/mod/mod_query.so
notion: /usr/lib64/notion/mod/mod_sm.so
notion: /usr/lib64/notion/mod/mod_sp.so
notion: /usr/lib64/notion/mod/mod_statusbar.so
notion: /usr/lib64/notion/mod/mod_tiling.so
notion: /usr/lib64/notion/mod/mod_xinerama.so
notion: /usr/lib64/notion/mod/mod_xkbevents.so
notion: /usr/lib64/notion/mod/mod_xrandr.so
Source checksums
----------------
http://downloads.sourceforge.net/project/notion/notion-3-2014052800-src.tar.bz2
:
CHECKSUM(SHA256) this package :
3619c90fb1f4b49cbddbfa8b94aa1d1e7e5a7e933764aea3ab3b25c6ef3c7027
CHECKSUM(SHA256) upstream package :
3619c90fb1f4b49cbddbfa8b94aa1d1e7e5a7e933764aea3ab3b25c6ef3c7027
https://fedorahosted.org/released/notion/notion.desktop :
CHECKSUM(SHA256) this package :
17a6565ff6b1d84bd589030eac91bd9d9be40ea50c3334fa48fb1f926971d88e
CHECKSUM(SHA256) upstream package :
17a6565ff6b1d84bd589030eac91bd9d9be40ea50c3334fa48fb1f926971d88e
Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13
Command line :/usr/bin/fedora-review -n notion
Buildroot used: fedora-20-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R,
PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.
More information about the rpmfusion-developers
mailing list