[Bug 3251] Review request: vdr-xineliboutput - xine-lib based software output device for VDR
RPM Fusion Bugzilla
noreply at rpmfusion.org
Mon May 26 18:17:26 CEST 2014
https://bugzilla.rpmfusion.org/show_bug.cgi?id=3251
--- Comment #9 from Antonio Trande <anto.trande at gmail.com> 2014-05-26 18:17:26 CEST ---
- Please, use CFLAGS="-I%{includedir}/ffmpeg" \
- /usr/lib64/vdr is already owned by vdr/vdr-devel.
Remove the line
%dir %{vdr_plugindir}
- Remove
%defattr(-,root,root,-)
- Why use %define?
%define build_cvs 1
%if 0%{?build_cvs}
%define cvsver 20140429
%endif
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
===== MUST items =====
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"GPL (v2 or later) (with incorrect FSF address)", "GPL (v2 or later)",
"Unknown or generated". 116 files have unknown license. Detailed output
of licensecheck in /home/sagitter/vdr-xineliboutput/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/locale/sk_SK,
/usr/share/locale/sk_SK/LC_MESSAGES
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /etc/vdr/plugins/xineliboutput,
/usr/share/locale/sk_SK, /usr/share/locale/sk_SK/LC_MESSAGES, /etc/vdr,
/etc/vdr/plugins
[!]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by: /usr/lib64/vdr(vdr-devel)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[!]: Each %files section contains %defattr if rpm < 4.4
Note: %defattr present but not needed
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[!]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 81920 bytes in 3 files.
[!]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[x]: Sources can be downloaded from URI in Source: tag
Note: Could not download Source0:
http://sourceforge.net/projects/xineliboutput/files/xineliboutput/vdr-
xineliboutput-1.1.0-20140429.tgz
See: http://fedoraproject.org/wiki/Packaging:Guidelines#Tags
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in vdr-
xineliboutput-plugin
[ ]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[?]: Spec use %global instead of %define unless justified.
Note: %define requiring justification: %define build_cvs 1, %define
cvsver 20140429, %define have_bluray 1
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: SourceX is a working URL.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package is
arched.
Rpmlint
-------
Checking: vdr-xineliboutput-1.1.0-4.cvs20140429.fc21.x86_64.rpm
vdr-xineliboutput-plugin-1.1.0-4.cvs20140429.fc21.x86_64.rpm
vdr-xineliboutput-1.1.0-4.cvs20140429.fc21.src.rpm
vdr-xineliboutput.x86_64: W: non-conffile-in-etc
/etc/vdr/plugins/xineliboutput/allowed_hosts.conf
vdr-xineliboutput.x86_64: W: non-conffile-in-etc
/etc/vdr/plugins/xineliboutput/black_720x576.mpg
vdr-xineliboutput.x86_64: W: non-conffile-in-etc
/etc/vdr/plugins/xineliboutput/nosignal_720x576.mpg
vdr-xineliboutput.x86_64: W: non-conffile-in-etc
/etc/vdr/plugins/xineliboutput/vdrlogo_720x576.mpg
vdr-xineliboutput.x86_64: W: no-manual-page-for-binary mpg2c
vdr-xineliboutput.x86_64: W: no-manual-page-for-binary vdr-sxfe
vdr-xineliboutput.x86_64: W: no-manual-page-for-binary vdr-fbfe
vdr-xineliboutput-plugin.x86_64: W: spelling-error %description -l en_US xine
-> zine, cine, sine
vdr-xineliboutput-plugin.x86_64: W: no-documentation
vdr-xineliboutput-plugin.x86_64: W: dangling-relative-symlink
/usr/lib64/vdr/libxineliboutput-fbfe.so.2.0.6
libxineliboutput-fbfe.so.2.0.6-cvs
vdr-xineliboutput-plugin.x86_64: W: dangling-relative-symlink
/usr/lib64/vdr/libxineliboutput-sxfe.so.2.0.6
libxineliboutput-sxfe.so.2.0.6-cvs
vdr-xineliboutput.src: W: spelling-error %description -l en_US xine -> zine,
cine, sine
vdr-xineliboutput.src:76: W: configure-without-libdir-spec
vdr-xineliboutput.src:89: W: rpm-buildroot-usage %prep DESTDIR=%{buildroot} \
vdr-xineliboutput.src: W: invalid-url Source0:
http://sourceforge.net/projects/xineliboutput/files/xineliboutput/vdr-xineliboutput-1.1.0-20140429.tgz
HTTP Error 404: Not Found
3 packages and 0 specfiles checked; 0 errors, 15 warnings.
Rpmlint (installed packages)
----------------------------
# rpmlint vdr-xineliboutput-plugin vdr-xineliboutput
vdr-xineliboutput-plugin.x86_64: W: spelling-error %description -l en_US xine
-> zine, cine, sine
vdr-xineliboutput-plugin.x86_64: W: no-documentation
vdr-xineliboutput-plugin.x86_64: W: dangling-relative-symlink
/usr/lib64/vdr/libxineliboutput-fbfe.so.2.0.6
libxineliboutput-fbfe.so.2.0.6-cvs
vdr-xineliboutput-plugin.x86_64: W: dangling-relative-symlink
/usr/lib64/vdr/libxineliboutput-sxfe.so.2.0.6
libxineliboutput-sxfe.so.2.0.6-cvs
vdr-xineliboutput.x86_64: W: non-conffile-in-etc
/etc/vdr/plugins/xineliboutput/allowed_hosts.conf
vdr-xineliboutput.x86_64: W: non-conffile-in-etc
/etc/vdr/plugins/xineliboutput/black_720x576.mpg
vdr-xineliboutput.x86_64: W: non-conffile-in-etc
/etc/vdr/plugins/xineliboutput/nosignal_720x576.mpg
vdr-xineliboutput.x86_64: W: non-conffile-in-etc
/etc/vdr/plugins/xineliboutput/vdrlogo_720x576.mpg
vdr-xineliboutput.x86_64: W: no-manual-page-for-binary mpg2c
vdr-xineliboutput.x86_64: W: no-manual-page-for-binary vdr-sxfe
vdr-xineliboutput.x86_64: W: no-manual-page-for-binary vdr-fbfe
2 packages and 0 specfiles checked; 0 errors, 11 warnings.
# echo 'rpmlint-done:'
Requires
--------
vdr-xineliboutput-plugin (rpmlib, GLIBC filtered):
config(vdr-xineliboutput-plugin)
libGL.so.1()(64bit)
libGLU.so.1()(64bit)
libX11.so.6()(64bit)
libXext.so.6()(64bit)
libXinerama.so.1()(64bit)
libXrender.so.1()(64bit)
libbluray.so.1()(64bit)
libc.so.6()(64bit)
libcap.so.2()(64bit)
libdbus-1.so.3()(64bit)
libdbus-glib-1.so.2()(64bit)
libdl.so.2()(64bit)
libextractor.so.3()(64bit)
libgcc_s.so.1()(64bit)
libgcc_s.so.1(GCC_3.0)(64bit)
libglib-2.0.so.0()(64bit)
libgobject-2.0.so.0()(64bit)
libjpeg.so.62()(64bit)
libjpeg.so.62(LIBJPEG_6.2)(64bit)
libm.so.6()(64bit)
libpthread.so.0()(64bit)
librt.so.1()(64bit)
libstdc++.so.6()(64bit)
libstdc++.so.6(CXXABI_1.3)(64bit)
libxine.so.2()(64bit)
rtld(GNU_HASH)
vdr(abi)(x86-64)
vdr-xineliboutput (rpmlib, GLIBC filtered):
libGL.so.1()(64bit)
libGLU.so.1()(64bit)
libX11.so.6()(64bit)
libXext.so.6()(64bit)
libXinerama.so.1()(64bit)
libXrender.so.1()(64bit)
libavutil.so.52()(64bit)
libavutil.so.52(LIBAVUTIL_52)(64bit)
libc.so.6()(64bit)
libdbus-1.so.3()(64bit)
libdbus-glib-1.so.2()(64bit)
libdl.so.2()(64bit)
libextractor
libgcc_s.so.1()(64bit)
libgcc_s.so.1(GCC_3.0)(64bit)
libgcc_s.so.1(GCC_3.3.1)(64bit)
libglib-2.0.so.0()(64bit)
libgobject-2.0.so.0()(64bit)
libjpeg.so.62()(64bit)
libjpeg.so.62(LIBJPEG_6.2)(64bit)
libm.so.6()(64bit)
libpthread.so.0()(64bit)
libxine.so.2()(64bit)
rtld(GNU_HASH)
xine-lib
Provides
--------
vdr-xineliboutput-plugin:
config(vdr-xineliboutput-plugin)
libvdr-xineliboutput.so.2.0.6()(64bit)
libxineliboutput-fbfe.so
libxineliboutput-fbfe.so.2.0.0-cvs()(64bit)
libxineliboutput-sxfe.so
libxineliboutput-sxfe.so.2.0.0-cvs()(64bit)
vdr-xineliboutput-plugin
vdr-xineliboutput-plugin(x86-64)
vdr-xineliboutput:
vdr-xineliboutput
vdr-xineliboutput(x86-64)
Unversioned so-files
--------------------
vdr-xineliboutput:
/usr/lib64/xine/plugins/2.4/post/xineplug_post_audiochannel.so
vdr-xineliboutput: /usr/lib64/xine/plugins/2.4/post/xineplug_post_autocrop.so
vdr-xineliboutput: /usr/lib64/xine/plugins/2.4/post/xineplug_post_swscale.so
vdr-xineliboutput: /usr/lib64/xine/plugins/2.4/xineplug_inp_xvdr.so
Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13
Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64-rpmfusion_free
-rn vdr-xineliboutput-1.1.0-4.cvs20140429.fc20.src.rpm
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R,
PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the rpmfusion-developers
mailing list