[Bug 2429] Review request: gens-gs - Sega Genesis, Sega CD, and Sega 32X emulator

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=2429

--- Comment #10 from Jeremy Newton <alexjnewt at gmail.com> 2014-10-05 22:18:54 CEST ---
(In reply to comment #9)
> (In reply to comment #8)
> > Unfortunately the maintainer of gen has no interest in retiring the package,
> > but yes if a conflict must be avoided, I'll patch it to not conflict with gens
> 
> Hm.. it doesn't make sense to have two packages that do the same thing that
> come from the same source, but please patch around the conflict.

Oh I appologise if it wasn't clear; gen-GS is a Fork of gens, with cleaner
code, a bunch of merged fixes and patches, and improved portability. I proposed
replacing gens with gensgs but the rpmfusion maintainer seemed uninterested and
closed the bug.

> > > [-]: Development (unversioned) .so files in -devel subpackage, if present.
> > >      Note: Unversioned so-files in private %_libdir subdirectory (see
> > >      attachment). Verify they are not in ld path.
> > I believe they're not, let me check to make sure.
> 
> You can ignore this.
Ok thanks

> > > [!]: Large data in /usr/share should live in a noarch subpackage if package is
> > >      arched.
> > >      Note: Arch-ed rpms have a total of 1996800 bytes in /usr/share
> > I take this is the doc files? If so, its an easy fix
> 
> Yes, but please keep README, COPYING, etc. in %doc in your mail %files list.
Yes agreed, will do

> > > gens-gs.src:46: W: configure-without-libdir-spec
> > Do you know what causes this? I'm unformillar with this rpmlint warning
> > Is this the libtool issue with configure.ac?
> 
> It's a false positive. It sees you modified configure.ac. Upon further looking
> at the %configure line, you should not need to pass prefix or build options.
> 
> > Do you think moving these will be necessary?
> 
> No.

And thanks again. 

I should be able to make the changes by tomorrow.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.