[Bug 3563] Review request: xvst - Downloading your favourite video clips from a lot of websites

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=3563

--- Comment #2 from Mario Blättermann <mario.blaettermann at gmail.com> 2015-03-18 23:37:11 CET ---
$ rpmlint -i -v *
xvst.x86_64: I: checking
xvst.x86_64: W: spelling-error Summary(en_US) favourite -> favorite, favoritism
The value of this tag appears to be misspelled. Please double-check.

xvst.x86_64: W: spelling-error %description -l en_US xVideoServiceThief ->
serviceability
The value of this tag appears to be misspelled. Please double-check.

xvst.x86_64: W: spelling-error %description -l en_US favourite -> favorite,
favoritism
The value of this tag appears to be misspelled. Please double-check.

xvst.x86_64: I: checking-url https://github.com/xVST/xVideoServiceThief
(timeout 10 seconds)
xvst.x86_64: W: no-manual-page-for-binary xvst
Each executable in standard binary directories should have a man page.

xvst.src: I: checking
xvst.src: W: spelling-error Summary(en_US) favourite -> favorite, favoritism
The value of this tag appears to be misspelled. Please double-check.

xvst.src: W: spelling-error %description -l en_US xVideoServiceThief ->
serviceability
The value of this tag appears to be misspelled. Please double-check.

xvst.src: W: spelling-error %description -l en_US favourite -> favorite,
favoritism
The value of this tag appears to be misspelled. Please double-check.

xvst.src: I: checking-url https://github.com/xVST/xVideoServiceThief (timeout
10 seconds)
xvst.src: I: checking-url
https://github.com/xVST/xVideoServiceThief/archive/cbfafe49f7ba1c85d4dcf51be17b49b035210412/xvst-2.5.2-cbfafe4.tar.gz
(timeout 10 seconds)
xvst-debuginfo.x86_64: I: checking
xvst-debuginfo.x86_64: I: checking-url
https://github.com/xVST/xVideoServiceThief (timeout 10 seconds)
xvst-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/xVideoServiceThief-cbfafe49f7ba1c85d4dcf51be17b49b035210412/src/pakunpak/pakunpak.h
The Free Software Foundation address in this file seems to be outdated or
misspelled.  Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.

xvst-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/xVideoServiceThief-cbfafe49f7ba1c85d4dcf51be17b49b035210412/src/pakunpak/pakunpak.cpp
The Free Software Foundation address in this file seems to be outdated or
misspelled.  Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.

3 packages and 0 specfiles checked; 2 errors, 7 warnings.


Rpmlint is quite silent. The incorrect FSF address needs to be reported
upstream, don't change the license text. Speeling errors are ignorable.

Whats the purpose of "Provides: xviservicethief = %{version}"? I couldn't find
any package of that name from an external repo, so that users of such a package
would benefit of. Well, I found this declaration in the spec file of the ROSA
package, but that one shouldn't be of particular importance for us. 

The binary package contains translations in /usr/share/xvst/languages. Those
files need to be handled by %find_lang.
Don't know if it works directly, because the project uses the strange
*.language extension for the non-qm files in that directory. Try it out as
follows:
%find_lang xVST --with-qt
And add this to the file list:
%exclude %{_datadir}/%{name}/languages/*qm
On the other hand, actually the *.language files are also locale files in
common sense, but I'm in doubt if find_lang is able to handle them. Maybe you
should ask in the packagers mailing list if it doesn't work.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.