[Bug 4182] Review request: ffmulticonverter - GUI File Format Converter

RPM Fusion Bugzilla noreply at rpmfusion.org
Fri Aug 12 18:19:46 CEST 2016


https://bugzilla.rpmfusion.org/show_bug.cgi?id=4182

--- Comment #2 from leigh scott <leigh123linux at gmail.com> 2016-08-12 18:19:46 CEST ---
The shebang errors need fixing

Checking: ffmulticonverter-1.8.0-1.fc26.noarch.rpm
          ffmulticonverter-1.8.0-1.fc26.src.rpm
ffmulticonverter.noarch: E: script-without-shebang
/usr/lib/python3.5/site-packages/ffmulticonverter/ffmulticonverter.py
ffmulticonverter.noarch: E: script-without-shebang
/usr/lib/python3.5/site-packages/ffmulticonverter/presets_dlgs.py
ffmulticonverter.noarch: E: script-without-shebang
/usr/lib/python3.5/site-packages/ffmulticonverter/about_dlg.py
ffmulticonverter.noarch: E: script-without-shebang
/usr/lib/python3.5/site-packages/ffmulticonverter/preferences_dlg.py
ffmulticonverter.noarch: E: script-without-shebang
/usr/lib/python3.5/site-packages/ffmulticonverter/progress.py
ffmulticonverter.src: W: spelling-error %description -l en_US ffmpeg -> MPEG
ffmulticonverter.src: W: spelling-error %description -l en_US unoconv ->
unconvinced
2 packages and 0 specfiles checked; 5 errors, 2 warnings.

This isn't the correct fix

chmod 755 %{buildroot}%{python3_sitelib}/%{name}/%{name}.py
chmod 755 %{buildroot}%{python3_sitelib}/%{name}/about_dlg.py
chmod 755 %{buildroot}%{python3_sitelib}/%{name}/presets_dlgs.py
chmod 755 %{buildroot}%{python3_sitelib}/%{name}/progress.py
chmod 755 %{buildroot}%{python3_sitelib}/%{name}/preferences_dlg.py

If you use the correct marco's you should get the error

see

https://dl.dropboxusercontent.com/u/6907158/ffmulticonverter.spec

also remove the gz from the man file

%{_mandir}/man1/%{name}.1.gz

to

%{_mandir}/man1/%{name}.1.*

and %prep should be changed from

%prep
%setup -q -n %{name}-%version

to

%prep
%setup -q

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.


More information about the rpmfusion-developers mailing list