[Bug 4105] New: Review request: sdcc-nonfree - Small Device C Compiler - nonfree files

[RPM Fusion Bugzilla]

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4105

             Bug #: 4105
           Summary: Review request: sdcc-nonfree - Small Device C Compiler
                    - nonfree files
    Classification: Unclassified
           Product: Package Reviews
           Version: Current
          Platform: All
        OS/Version: GNU/Linux
            Status: NEW
          Severity: normal
          Priority: P5
         Component: Review Request
        AssignedTo: rpmfusion-package-review at rpmfusion.org
        ReportedBy: rrankin at ihug.com.au
                CC: rpmfusion-package-review at rpmfusion.org
            Blocks: 2


Spec URL:
https://github.com/rrankin/sdcc-nonfree/blob/master/sdcc-nonfree.spec

Source URL:
https://github.com/rrankin/sdcc-nonfree/blob/master/sdcc-nonfree-3.6.0-1.fc24.src.rpm

Description:

Files derived from Microchip files which are licensed for
use for Microchip devices only. Files used for compiling code for
14 and 16 bit PIC processors. The sdcc --use-non-free flag must
be used to access these files during compilation and linking.

License:

Restricting use for Microchip devices only makes license on the files
in this package non-free from a Fedora perspective.

Rpmlint:

rpmlint sdcc-nonfree.spec
sdcc-nonfree.spec:51: W: configure-without-libdir-spec
0 packages and 1 specfiles checked; 0 errors, 1 warnings.

note: %configure is not used as files end up in wrong directory
$ rpmlint sdcc-nonfree-3.6.0-1.fc24.x86_64.rpm
sdcc-nonfree.x86_64: W: invalid-license Redistributable but use for Microchip
devices only
sdcc-nonfree.x86_64: E: arch-dependent-file-in-usr-share
/usr/share/sdcc/non-free/lib/pic16/libdev18f66j60.lib
sdcc-nonfree.x86_64: W: binaryinfo-readelf-failed
/usr/share/sdcc/non-free/lib/pic16/libdev18f66j60.lib readelf: Error:
/tmp/rpmlint.sdcc-nonfree-3.6.0-1.fc24.x86_64.rpm.fjysaswk/usr/share/sdcc/non-free/lib/pic16/libdev18f66j60.lib:
did not find a valid archive header

... Repeated for each .lib file in package

sdcc-nonfree.x86_64: W: no-documentation
sdcc-nonfree.x86_64: W: devel-file-in-non-devel-package
/usr/share/sdcc/non-free/include/pic14/pic16lf1829.h

... Repeats for each .h file in package

sdcc-nonfree.x86_64: W: devel-file-in-non-devel-package
/usr/share/sdcc/non-free/include/pic16/pic18lf4580.h

1 packages and 0 specfiles checked; 724 errors, 1452 warnings.

Notes:

1  W: invalid-license  - Licence not suitable for Fedora

2 E: arch-dependent-file-in-usr-share - The .lib files are not lib files
        to be run on the host machine but rather to be included in the 
        generated PIC code. The .libs files may be arch dependant only
        do to the endian of the host machine. 
        /usr/share is where sdcc expects to find them.

3 W: binaryinfo-readelf-failed - The .lib files are not elf files.

4 W: no-documentation - All documentation is in sdcc package

5 W: devel-file-in-non-devel-package - The .h files are required for
    sdcc operation on PIC code and thus should not be in a -devel
    package 

$ rpmlint sdcc-nonfree-devel-3.6.0-1.fc24.noarch.rpm
sdcc-nonfree-devel.noarch: W: invalid-license Redistributable but use for
Microchip devices only
sdcc-nonfree-devel.noarch: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

Notes:
1 Invalid license is keeping these files out of Fedora
2 Contains source files which are own documentation

This is my first rpmfusion package I am a sponsored Fedora packager.

-- 
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.