[Bug 3887] Review request: display-dhammapada - Displays a verse from the Dhammapada

RPM Fusion Bugzilla noreply at rpmfusion.org
Thu Sep 8 17:48:03 CEST 2016


http://bugzilla.rpmfusion.org/show_bug.cgi?id=3887

Nicolas Chauvet <kwizart at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
             Blocks|2                           |3
           Assignee|rpmfusion-package-review at rp |kwizart at gmail.com
                   |mfusion.org                 |

--- Comment #1 from Nicolas Chauvet <kwizart at gmail.com> ---
While public domain is probably correct for the original content, your software
to display it is licensed as GPLv3(+ ?), this should appear in the license
field of the RPM with (idealy) a correct license file added to the upstream
project.

* Please fix the indent of the description (avoid space in the beginning of new
lines and at the top. And use the full allowed 80 characters.

* Drop unneeded %define _hardened_build 1 (this is the default nowadays)

* Use %make_build and %make_install macros

* Drop uneeded defattr

* Verify that all your directories are owned by the package.

* Use wildcard for manpages compression extension.

* There are spurious spaces in the beginning of some sections, please remove
and keep 2 spaces at the end of earch section.

So to me this should be provided in the free section, do you agree ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.rpmfusion.org/pipermail/rpmfusion-developers/attachments/20160908/9990a7d5/attachment.html>


More information about the rpmfusion-developers mailing list