[Bug 3965] Review request: miam-player - Miam-Player is a cross-platform open source music player

[RPM Fusion Bugzilla]

http://bugzilla.rpmfusion.org/show_bug.cgi?id=3965

leigh scott <leigh123linux at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |leigh123linux at gmail.com

--- Comment #15 from leigh scott <leigh123linux at gmail.com> ---
A couple of things.

you have this in the spec file.

%check
appstream-util validate-relax --nonet
%{buildroot}%{_datadir}/appdata/%{name}.appdata.xml

But have missed the build requires needed for it, add

BuildRequires: libappstream-glib


second is the wrong use of LDFLAGS

%build
%{_qt5_qmake} \
    QMAKE_CFLAGS="%{optflags}" \
    QMAKE_CXXFLAGS="%{optflags}" \
    QMAKE_LFLAGS="%{optflags} -Wl,--as-needed" \
    LIB_SUFFIX="$(echo %_lib | cut -b4-)" \
    CONFIG+="no_rpath recheck config_libass_link debug" 
%make_build

You use optflags when it should be ldflags, change to


%build
%{_qt5_qmake} \
    QMAKE_CFLAGS="${RPM_OPT_FLAGS}" \
    QMAKE_CXXFLAGS="${RPM_OPT_FLAGS}" \
    QMAKE_LFLAGS="${RPM_LD_FLAGS} -Wl,--as-needed" \
    LIB_SUFFIX="$(echo %_lib | cut -b4-)" \
    CONFIG+="no_rpath recheck config_libass_link debug" 
%make_build

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.rpmfusion.org/pipermail/rpmfusion-developers/attachments/20160917/3bdb7fea/attachment.html>