rpms/openafs/F-17 afs.conf.systemd, NONE, 1.1 openafs-1.6.1-systemd-env-vars.patch, NONE, 1.1 openafs-1.6.1-systemd-execpoststart.patch, NONE, 1.1 openafs-1.6.1-systemd-kmod-name.patch, NONE, 1.1 openafs-1.6.1-systemd-no-cellservdb.patch, NONE, 1.1 posthooks.sh, NONE, 1.1 setcrypt.sh, NONE, 1.1 sysnames.sh, NONE, 1.1 .cvsignore, 1.8, 1.9 openafs.spec, 1.26, 1.27 sources, 1.11, 1.12 openafs-1.6.1-int31-partsize.patch, 1.1, NONE

Author: ktdreyer Update of /cvs/free/rpms/openafs/F-17 In directory old02.ovh.rpmfusion.lan:/tmp/cvs-serv25205 Modified Files: .cvsignore openafs.spec sources Added Files: afs.conf.systemd openafs-1.6.1-systemd-env-vars.patch openafs-1.6.1-systemd-execpoststart.patch openafs-1.6.1-systemd-kmod-name.patch openafs-1.6.1-systemd-no-cellservdb.patch posthooks.sh setcrypt.sh sysnames.sh Removed Files: openafs-1.6.1-int31-partsize.patch Log Message: * Tue Jan 22 2013 Ken Dreyer <ktdreyer(a)ktdreyer.com&gt; 0:1.6.2-0.pre3 - Update to OpenAFS 1.6.2 pre-release 3 --- NEW FILE afs.conf.systemd --- # Use this file to pass additional options to the afsd and bosserver # executables. # Systemd will pass $AFSD_ARGS to afsd. # You may want to add more settings below. AFSD_ARGS="-nosettime -afsdb -dynroot -fakestat" # OpenAFS Client Cache Options # Default: Memcache - Quick and easy, 100 MB of memory used CACHE="-memcache -blocks 102400" # Disk based cache - Use this for servers. Set size in /etc/openafs/cacheinfo #CACHE="-cachedir /var/cache/openafs" # Fine-tuned AFS client configuration options. These affect system # performance. # Normal workstations, and servers that use AFS sparingly OPTIONS="-daemons 3" # For servers, greater AFS performance, and more memory/processes used # Use these options with the disk based cache settings above. # OPTIONS="-daemons 5 -chunksize 18 -volumes 512" # Directory to use for configuration information: CONFDIR="-confdir /etc/openafs" # AFS server initialization #BOSSERVER_ARGS= openafs-1.6.1-systemd-env-vars.patch: openafs-client.service | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- NEW FILE openafs-1.6.1-systemd-env-vars.patch --- From: Ken Dreyer <ktdreyer(a)ktdreyer.com&gt; Date: Mon, 8 Oct 2012 20:59:43 -0600 Subject: [PATCH 4/5] systemd: add more environment variables to openafs-client.service At the risk of deviating too far from upstream, this permits a few more user-friendly environment variables in /etc/sysconfig/openafs. Change-Id: Ib0938b2865005fc1f1b1c49dfda0d4bf92957004 --- src/packaging/RedHat/openafs-client.service | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/packaging/RedHat/openafs-client.service b/src/packaging/RedHat/openafs-client.service index 89a344f..719aed77 100644 --- a/src/packaging/RedHat/openafs-client.service +++ b/src/packaging/RedHat/openafs-client.service @@ -6,7 +6,7 @@ After=syslog.target network.target Type=forking EnvironmentFile=/etc/sysconfig/openafs ExecStartPre=/sbin/modprobe openafs -ExecStart=/usr/sbin/afsd $AFSD_ARGS +ExecStart=/usr/sbin/afsd $AFSD_ARGS $CACHE $OPTIONS $CONFDIR ExecStop=/bin/umount /afs ExecStop=/usr/sbin/afsd -shutdown ExecStop=/sbin/rmmod libafs -- 1.7.11.7 openafs-1.6.1-systemd-execpoststart.patch: openafs-client.service | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- NEW FILE openafs-1.6.1-systemd-execpoststart.patch --- From: Jack Neely <jjneely(a)ncsu.edu&gt; Date: Wed, 7 Nov 2012 17:00:37 -0500 Subject: [PATCH] systemd: Implement hooks for tuning the AFS client This makes a generic way to modify the behavior of the AFS client similar to the old style afs_post_init bash function. --- src/packaging/RedHat/openafs-client.service | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/packaging/RedHat/openafs-client.service b/src/packaging/RedHat/openafs-client.service index a2348cb..29548ac 100644 --- a/src/packaging/RedHat/openafs-client.service +++ b/src/packaging/RedHat/openafs-client.service @@ -7,6 +7,7 @@ Type=forking EnvironmentFile=/etc/sysconfig/openafs ExecStartPre=/sbin/modprobe openafs ExecStart=/usr/sbin/afsd $AFSD_ARGS $CACHE $OPTIONS $CONFDIR +ExecStartPost=/usr/libexec/openafs/posthooks.sh ExecStop=/bin/umount /afs ExecStop=/usr/sbin/afsd -shutdown ExecStop=/sbin/rmmod libafs -- 1.7.1 openafs-1.6.1-systemd-kmod-name.patch: openafs-client.service | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- NEW FILE openafs-1.6.1-systemd-kmod-name.patch --- From: Ken Dreyer <ktdreyer(a)ktdreyer.com&gt; Date: Mon, 8 Oct 2012 20:55:50 -0600 Subject: [PATCH 2/5] systemd: unload module "libafs" Load the module as "openafs", but unload it using the name "libafs". Change-Id: Ib7d3d9b80ff58e9cded9a3171a5b003f1995a5b7 --- src/packaging/RedHat/openafs-client.service | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/packaging/RedHat/openafs-client.service b/src/packaging/RedHat/openafs-client.service index 2ee652a..a5fb287 100644 --- a/src/packaging/RedHat/openafs-client.service +++ b/src/packaging/RedHat/openafs-client.service @@ -9,7 +9,7 @@ ExecStartPre=/sbin/modprobe openafs ExecStart=/usr/vice/etc/afsd $AFSD_ARGS ExecStop=/bin/umount /afs ExecStop=/usr/vice/etc/afsd -shutdown -ExecStop=/sbin/rmmod openafs +ExecStop=/sbin/rmmod libafs KillMode=none [Install] -- 1.7.11.7 openafs-1.6.1-systemd-no-cellservdb.patch: openafs-client.service | 3 --- 1 file changed, 3 deletions(-) --- NEW FILE openafs-1.6.1-systemd-no-cellservdb.patch --- From: Ken Dreyer <ktdreyer(a)ktdreyer.com&gt; Date: Mon, 8 Oct 2012 20:55:12 -0600 Subject: [PATCH 1/5] systemd: skip CellServDB manipulation Change-Id: I23544f183c0423b208b6465c8d7184d64b6b4a15 --- src/packaging/RedHat/openafs-client.service | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/packaging/RedHat/openafs-client.service b/src/packaging/RedHat/openafs-client.service index 936762e..2ee652a 100644 --- a/src/packaging/RedHat/openafs-client.service +++ b/src/packaging/RedHat/openafs-client.service @@ -5,8 +5,6 @@ After=syslog.target network.target [Service] Type=forking EnvironmentFile=/etc/sysconfig/openafs -ExecStartPre=/bin/sed -n 'w/usr/vice/etc/CellServDB' /usr/vice/etc/CellServDB.local /usr/vice/etc/CellServDB.dist -ExecStartPre=/bin/chmod 0644 /usr/vice/etc/CellServDB ExecStartPre=/sbin/modprobe openafs ExecStart=/usr/vice/etc/afsd $AFSD_ARGS ExecStop=/bin/umount /afs -- 1.7.11.7 --- NEW FILE posthooks.sh --- #!/bin/bash # openafs-posthooks.sh # # Copyright 2012 NC State University # Written by Jack Neely <jjneely(a)ncsu.edu&gt; # # SDG # # This script runs as a ExecStartPost from the openafs-client.service # systemd unit. It will source files in /etc/openafs/posthooks.d # where an admin may place scripts to fine tune the OpenAFS client # operations, such as turning on encryption. The sysnames.sh script # in that directory comes with this package. HOOKS=/etc/openafs/posthooks.d if [ -d $HOOKS ] ; then for i in $HOOKS/*.sh ; do if [ -r "$i" ]; then . $i fi done unset i fi --- NEW FILE setcrypt.sh --- #!/bin/bash # By default, turn on encryption of the AFS protocol /usr/bin/fs setcrypt -crypt on --- NEW FILE sysnames.sh --- #!/bin/bash # /usr/libexec/openafs/sysnames # Set custom sysnames after starting the afsd service. # Runs as "ExecStartPost" in openafs-client.service. # Figure out what we are _ARCH=`uname -i | sed 's/x86_64/amd64/'` _KERN=`uname -r | sed 's/\([0-9]\+\)\.\([0-9]\+\)\..*/\1\2/'` _DIST="" for d in fedora centos redhat ; do if [ -f "/etc/$d-release" ] ; then _DIST=$d break fi done # What version of the distribution are we? Cut off the Client|Server # mess from RHEL _REL=`/bin/rpm -qf --qf '%{version}\n' /etc/${_DIST}-release | sed 's/\([0-9]\+\)[a-zA-Z]\+/\1/'` # Sysname list. The order here is from specific to general, with a # fallback to the compiled-in value from /usr/bin/sys. This will be # used as the sysname search path. SYSNAMELIST="${_ARCH}_${_DIST}_${_REL} ${_ARCH}_linux${_KERN} $(/usr/bin/sys)" # Set the sysname if [ -n "$SYSNAMELIST" ] ; then _FLAG=0 _CMD="" for SYSNAME in $SYSNAMELIST ; do if [ $_FLAG == "1" ] ; then _CMD="$_CMD -newsys $SYSNAME" else _FLAG=1 _CMD="/usr/bin/fs sysname $SYSNAME" fi done fi $_CMD > /dev/null Index: .cvsignore =================================================================== RCS file: /cvs/free/rpms/openafs/F-17/.cvsignore,v retrieving revision 1.8 retrieving revision 1.9 diff -u -r1.8 -r1.9 --- .cvsignore 4 Apr 2012 19:20:12 -0000 1.8 +++ .cvsignore 25 Jan 2013 09:09:46 -0000 1.9 @@ -1,2 +1,2 @@ -openafs-1.6.1-src.tar.bz2 -openafs-1.6.1-doc.tar.bz2 +openafs-1.6.2pre3-src.tar.bz2 +openafs-1.6.2pre3-doc.tar.bz2 Index: openafs.spec =================================================================== RCS file: /cvs/free/rpms/openafs/F-17/openafs.spec,v retrieving revision 1.26 retrieving revision 1.27 diff -u -r1.26 -r1.27 --- openafs.spec 24 Aug 2012 16:56:50 -0000 1.26 +++ openafs.spec 25 Jan 2013 09:09:46 -0000 1.27 @@ -10,27 +10,50 @@ %define sysname amd64_linux26 %endif +%define pre pre3 + Summary: Enterprise Network File System Name: openafs -Version: 1.6.1 -Release: 4%{?dist} +Version: 1.6.2 +Release: 0.%{pre}%{?dist} License: IBM Group: System Environment/Daemons URL: http://www.openafs.org -Source0: http://dl.openafs.org/dl/%{version}/%{name}-%{version}-src.tar.bz2 -Source1: http://dl.openafs.org/dl/%{version}/%{name}-%{version}-doc.tar.bz2 +Source0: http://dl.openafs.org/dl/candidate/%{version}%{pre}/%{name}-%{version}%{p... +Source1: http://dl.openafs.org/dl/candidate/%{version}%{pre}/%{name}-%{version}%{p... Source11: http://grand.central.org/dl/cellservdb/CellServDB Source12: cacheinfo Source13: openafs.init Source14: afs.conf +# Similar to afs.conf, but for systemd. +Source15: afs.conf.systemd +# Handle AFS post init scriptlets for systemd +Source16: posthooks.sh +# Default post init scripts +Source20: sysnames.sh +Source21: setcrypt.sh BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) BuildRequires: krb5-devel, pam-devel, ncurses-devel, flex, byacc, bison BuildRequires: automake, autoconf Patch0: openafs-1.6.0-fPIC.patch -# Upstream patch to fix fileservers with >2TB partitions -Patch1: openafs-1.6.1-int31-partsize.patch +# systemd: Skip CellServDB manipulation +Patch1: openafs-1.6.1-systemd-no-cellservdb.patch +# systemd: unload the proper kernel module +Patch2: openafs-1.6.1-systemd-kmod-name.patch +# systemd: use FHS-style paths instead of transarc paths +Patch3: openafs-1.6.1-systemd-fhs.patch +# systemd: add additional user-friendly environment vars +Patch4: openafs-1.6.1-systemd-env-vars.patch +# Add ExecPostStart "sysnames" helper script. +Patch5: openafs-1.6.1-systemd-execpoststart.patch + +# Use systemd unit files on Fedora 18 and above. +%if 0%{?fedora} >= 18 || 0%{?rhel} >= 7 + %global _with_systemd 1 +%endif + %description The AFS distributed filesystem. AFS is a distributed filesystem @@ -45,7 +68,14 @@ %package client Summary: OpenAFS Filesystem client Group: System Environment/Daemons -Requires(post): bash, coreutils, chkconfig, selinux-policy-targeted +Requires(post): bash, coreutils, selinux-policy-targeted +%if 0%{?_with_systemd} +Requires(preun): systemd +Requires(postun): systemd +Requires(post): systemd +%else +Requires(post): chkconfig +%endif Requires: %{name}-kmod >= %{version} Requires: openafs = %{version} Provides: %{name}-kmod-common = %{version} @@ -82,6 +112,11 @@ Summary: OpenAFS Filesystem Server Group: System Environment/Daemons Requires: openafs-client = %{version}, openafs = %{version} +%if 0%{?_with_systemd} +Requires(preun): systemd +Requires(postun): systemd +Requires(post): systemd +%endif %description server The AFS distributed filesystem. AFS is a distributed filesystem @@ -93,14 +128,17 @@ Cell. %prep -%setup -q -b 1 -n openafs-%{version} +%setup -q -b 1 -n openafs-%{version}%{pre} # This changes osconf.m4 to build with -fPIC on i386 and x86_64 %patch0 -# # This allows fileservers to report correct partition usage on -# partitions greater than 2TB. -%patch1 -p1 +# systemd unit file changes for RPM Fusion +%patch1 -p1 -b .cellservdb +%patch2 -p1 -b .kmod +%patch3 -p1 -b .fhs +%patch4 -p1 -b .envvars +%patch5 -p1 -b .execpoststart # Convert the licese to UTF-8 mv src/LICENSE src/LICENSE~ @@ -149,13 +187,38 @@ install -p -m 644 %{SOURCE12} ${RPM_BUILD_ROOT}%{_sysconfdir}/openafs echo %{thiscell} > ${RPM_BUILD_ROOT}%{_sysconfdir}/openafs/ThisCell -# install the init script -mkdir -p ${RPM_BUILD_ROOT}%{_sysconfdir}/rc.d/init.d -install -m 755 %{SOURCE13} ${RPM_BUILD_ROOT}%{_sysconfdir}/rc.d/init.d/openafs +# install the init file(s) +%if 0%{?_with_systemd} + # install systemd service files + mkdir -p ${RPM_BUILD_ROOT}%{_unitdir} + pushd src/packaging/RedHat + install -p -m 644 openafs-client.service \ + ${RPM_BUILD_ROOT}%{_unitdir}/openafs-client.service + install -p -m 644 openafs-server.service \ + ${RPM_BUILD_ROOT}%{_unitdir}/openafs-server.service + popd + # install "sysnames" helper script + install -p -m 755 %{SOURCE16} \ + ${RPM_BUILD_ROOT}%{_libexecdir}/openafs/posthooks.sh + install -d -m 755 \ + ${RPM_BUILD_ROOT}%{_sysconfdir}/openafs/posthooks.d + install -p -m 644 %{SOURCE20} \ + ${RPM_BUILD_ROOT}%{_sysconfdir}/openafs/posthooks.d/sysnames.sh + install -p -m 644 %{SOURCE21} \ + ${RPM_BUILD_ROOT}%{_sysconfdir}/openafs/posthooks.d/setcrypt.sh +%else + # install legacy SysV init script + mkdir -p ${RPM_BUILD_ROOT}%{_sysconfdir}/rc.d/init.d + install -m 755 %{SOURCE13} ${RPM_BUILD_ROOT}%{_sysconfdir}/rc.d/init.d/openafs +%endif # sysconfig file mkdir -p ${RPM_BUILD_ROOT}%{_sysconfdir}/sysconfig -install -m 644 %{SOURCE14} ${RPM_BUILD_ROOT}%{_sysconfdir}/sysconfig/openafs +%if 0%{?_with_systemd} + install -m 644 %{SOURCE15} ${RPM_BUILD_ROOT}%{_sysconfdir}/sysconfig/openafs +%else + install -m 644 %{SOURCE14} ${RPM_BUILD_ROOT}%{_sysconfdir}/sysconfig/openafs +%endif # Include the vlclient binary install -m 755 src/vlserver/vlclient ${RPM_BUILD_ROOT}/usr/sbin/vlclient @@ -203,11 +266,18 @@ # don't restart in post because kernel modules could well have changed %post /sbin/ldconfig -if [ $1 = 1 ]; then +%if 0%{?_with_systemd} + # systemd unit files are in the -client and -server subpackages. +%else + if [ $1 = 1 ]; then /sbin/chkconfig --add openafs -fi + fi +%endif %post client +%if !0%{?_with_systemd} + %systemd_post openafs-client.service +%endif # if this is owned by the package, upgrades with afs running can't work if [ ! -d /afs ] ; then mkdir -m 700 /afs @@ -215,15 +285,44 @@ fi exit 0 +%post server +%if !0%{?_with_systemd} + %systemd_post openafs-server.service +%endif + %preun -if [ "$1" = 0 ] ; then +%if 0%{?_with_systemd} + # systemd unit files are in the -client and -server subpackages. +%else + if [ "$1" = 0 ] ; then /sbin/chkconfig --del openafs %{_sysconfdir}/rc.d/init.d/openafs stop && rmdir /afs -fi -exit 0 + fi + exit 0 +%endif + +%preun client +%if 0%{?_with_systemd} + %systemd_preun openafs-client.service +%endif + +%preun server +%if 0%{?_with_systemd} + %systemd_preun openafs-server.service +%endif %postun -p /sbin/ldconfig +%postun client +%if 0%{?_with_systemd} + %systemd_postun openafs-client.service +%endif + +%postun server +%if 0%{?_with_systemd} + %systemd_postun openafs-server.service +%endif + %post devel -p /sbin/ldconfig %postun devel -p /sbin/ldconfig @@ -233,10 +332,16 @@ %files %defattr(-, root, root, -) +%dir %{_sysconfdir}/openafs +%dir %{_libexecdir}/openafs %doc src/LICENSE README NEWS README.DEVEL README.GIT README.PTHREADED_UBIK %doc README.WARNINGS README-WINDOWS %config(noreplace) %{_sysconfdir}/sysconfig/* +%if 0%{?_with_systemd} +# systemd files are in -client and -server subpackages +%else %{_sysconfdir}/rc.d/init.d/* +%endif %{_bindir}/aklog %{_bindir}/bos %{_bindir}/fs @@ -274,11 +379,15 @@ %files client %defattr(-, root, root) -%dir %{_sysconfdir}/openafs %dir %{_localstatedir}/cache/openafs %config(noreplace) %{_sysconfdir}/openafs/CellServDB %config(noreplace) %{_sysconfdir}/openafs/ThisCell %config(noreplace) %{_sysconfdir}/openafs/cacheinfo +%if 0%{?_with_systemd} +%{_unitdir}/openafs-client.service +%{_libexecdir}/openafs/posthooks.sh +%{_sysconfdir}/openafs/posthooks.d/*.sh +%endif %{_bindir}/afsio %{_bindir}/cmdebug %{_bindir}/xstat_cm_test @@ -286,12 +395,27 @@ %files server %defattr(-,root,root) +%if 0%{?_with_systemd} +%{_unitdir}/openafs-server.service +%endif %{_bindir}/afsmonitor %{_bindir}/asetkey %{_bindir}/scout %{_bindir}/udebug %{_bindir}/xstat_fs_test -%{_libexecdir}/openafs +%{_libexecdir}/openafs/buserver +%{_libexecdir}/openafs/dafileserver +%{_libexecdir}/openafs/dasalvager +%{_libexecdir}/openafs/davolserver +%{_libexecdir}/openafs/fileserver +%{_libexecdir}/openafs/kaserver +%{_libexecdir}/openafs/ptserver +%{_libexecdir}/openafs/salvager +%{_libexecdir}/openafs/salvageserver +%{_libexecdir}/openafs/upclient +%{_libexecdir}/openafs/upserver +%{_libexecdir}/openafs/vlserver +%{_libexecdir}/openafs/volserver %{_sbindir}/dafssync-debug %{_sbindir}/fssync-debug %{_sbindir}/salvsync-debug @@ -330,12 +454,40 @@ %{_datadir}/openafs/C/afszcm.cat %changelog -* Thu Aug 23 2012 Jack Neely <jjneely(a)ncsu.edu&gt; 0:1.6.1-4 +* Tue Jan 22 2013 Ken Dreyer <ktdreyer(a)ktdreyer.com&gt; 0:1.6.2-0.pre3 +- Update to OpenAFS 1.6.2 pre-release 3 + +* Wed Dec 26 2012 Ken Dreyer <ktdreyer(a)ktdreyer.com&gt; 0:1.6.2-0.pre2 +- Update to OpenAFS 1.6.2 pre-release 2 + +* Thu Dec 13 2012 Ken Dreyer <ktdreyer(a)ktdreyer.com&gt; 0:1.6.2-0.pre1 +- Update to OpenAFS 1.6.2 pre-release 1 +- Remove upstreamed patches + +* Tue Dec 11 2012 Ken Dreyer <ktdreyer(a)ktdreyer.com&gt; 0:1.6.1-9 +- Correct bosserver path in systemd unit file + +* Wed Nov 08 2012 Jack Neely <jjneely(a)ncsu.edu&gt; 0:1.6.1-8 +- Implement a directory for sourced post init scripts. These + fine tune the AFS client's behavior after startup and live in + /etc/openafs/posthooks.d/ + +* Wed Nov 07 2012 Jack Neely <jjneely(a)ncsu.edu&gt; 0:1.6.1-7 +- Fine tune the systemd version of /etc/sysconfig/openafs + to use -fakestat and have some options settable by the user. + +* Mon Oct 8 2012 Ken Dreyer <ktdreyer(a)ktdreyer.com&gt; 0:1.6.1-6 +- Enable systemd unit files for F18 and above + +* Thu Aug 23 2012 Jack Neely <jjneely(a)ncsu.edu&gt; 0:1.6.1-5 - Update /etc/sysconfig/openafs to have some more current default settings. - AFS_CACHE_DIR is now pre-poplated with the default value - Encryption is used by default +* Wed Aug 22 2012 Ken Dreyer <ktdreyer(a)ktdreyer.com&gt; 0:1.6.1-4 +- Upstream patch for new glibc + * Wed Aug 22 2012 Ken Dreyer <ktdreyer(a)ktdreyer.com&gt; 0:1.6.1-3 - Patch to allow fileservers to report correct partition usage data on partitions sizes greater than 2TB. Index: sources =================================================================== RCS file: /cvs/free/rpms/openafs/F-17/sources,v retrieving revision 1.11 retrieving revision 1.12 diff -u -r1.11 -r1.12 --- sources 4 Apr 2012 19:20:12 -0000 1.11 +++ sources 25 Jan 2013 09:09:46 -0000 1.12 @@ -1,2 +1,2 @@ -7215609990a2b253f8980fc1e1da0530 openafs-1.6.1-src.tar.bz2 -73d9a86038e827f95de90cf56c940bf7 openafs-1.6.1-doc.tar.bz2 +d4130bb529c26c2f0d232410f96004a4 openafs-1.6.2pre3-src.tar.bz2 +03ad50744114a8c2839851570a6faf44 openafs-1.6.2pre3-doc.tar.bz2 --- openafs-1.6.1-int31-partsize.patch DELETED ---