[Bug 1153] Review request: m2vmp2cut - MPEG2 frame accurate cutter
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1153
--- Comment #6 from Andrea Musuruane <musuruan(a)gmail.com> 2010-12-18 14:13:36 ---
(In reply to comment #5)
Thanks for all the good comments! I have updated the package now.
> 1. Not compiled with %{optflags}:
CFLAGS is already used, and there are compilation commands in C files (!). So
this was slightly more involved than usual. But I think I've fixed all
occurrences.
Actually no. Now you add %{optflags} but you don't override the m2vmp2cut
cflags. For example:
gcc %{optflags} -O3 -D_FILE_OFFSET_BITS=64 -D_LARGEF
ILE_SOURCE -Wall -Wstrict-prototypes -pedantic -Wno-long-long -Wcast-align
-Wpoi
nter-arith -W -Wwrite-strings -Wcast-qual -Wshadow [..]
"-O3" and "-Wall -Wstrict-prototypes -pedantic -Wno-long-long
-Wcast-align
-Wpointer-arith -W -Wwrite-strings -Wcast-qual -Wshadow" must not be included
(because they override %{optflags})
Everything else seems fine.
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.