[Bug 679] Review request: HandBrake - Multithreaded DVD to MPEG-4 converter

http://bugzilla.rpmfusion.org/show_bug.cgi?id=679 Orcan Ogetbil <oget.fedora(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oget.fedora(a)gmail.com --- Comment #1 from Orcan Ogetbil <oget.fedora(a)gmail.com&gt; 2009-06-23 07:48:57 --- There is one major issue with this package: # These are sources required to build Handbrake - currently not in Fedora or # RPM Fusion - or they are tool old Source100: http://download.m0k.org/handbrake/contrib/ffmpeg-r15462.tar.gz Source101: http://download.m0k.org/handbrake/contrib/libdca-r81-strapped.tar.gz Source102: http://download.m0k.org/handbrake/contrib/libmp4v2-r45.tar.gz This is not allowed by Fedora/RPMFusion policies. If you want to have HandBrake in RPMFusion, you must - package the missing sources separetely (remember the "latest version must be packaged" rule), - patch HandBrake to use the recent version of these libraries that we have in Fedora/RPMFusion. See: http://fedoraproject.org/wiki/Packaging/Guidelines#Duplication_of_system_... There are also other issues like * Instead of doing mv $RPM_BUILD_ROOT/%{_prefix}/local/bin/* $RPM_BUILD_ROOT/%{_bindir}/ you need to set the prefix during building * Use the latest scriptlets http://fedoraproject.org/wiki/Packaging/ScriptletSnippets * No more --vendor="fedora" in new packages -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.