[Bug 195] Review request: perl-Crypt-IDEA - Perl interface to IDEA block cipher
http://bugzilla.rpmfusion.org/show_bug.cgi?id=195
--- Comment #14 from Paul Howarth <paul(a)city-fan.org> 2009-01-21 14:26:34 ---
(In reply to comment #1)
The package seems in shape. There are a suggestion (!), a few issues
that need
to be corrected (*) and a question (?)
! If you use a delimiter other than / on sed, it will make things easier to
read.
Done.
* Please explain all non-trivial things you do in a SPEC file
(especially the
sed and rm commands) as comments
I added a comment about the sed command. The other commands are all basically
idioms found in all perl modules (see the perl spec template from the
rpmdevtools package) relating to packaging perl modules sensibly in rpm format
without having them all conflict with each other - the removed files aren't
needed in rpm-based distributions. We don't want to add identical commentary to
hundreds (thousands?) of perl module packages,do we?
* Please preserve the timestamps of non-compiled files.
This is already done with the exception of IDEA.pm, and the Crypt::IDEA
manpage, which is derived from IDEA.pm. The IDEA.pm is edited in %prep and I
don't think it's appropriate to fiddle the timestamp of the edited file to be
the same as the original one.
* The file "changes" should go to %doc
Done.
? Packages must not own files or directories already owned by other
packages.
%{perl_vendorarch}/Crypt/ and %{perl_vendorarch}/auto/Crypt/ are owned by
crypto-utils. But there is an exception rule for perl packages and I believe
this package falls into that category. Am I right?
The guideline about directory ownership basically states that a package should
own all directories that it uses that are not already owned by by any of its
dependency packages. It is very common amongst perl modules for unrelated (i.e.
no dependency relationship) packages to own the same directories because of the
directory hierarchy used for perl module install paths, e.g. all
architecture-specific perl-Crypt-* packages will own {perl_vendorarch}/Crypt/
unless they depend on another perl-Crypt-* package. crypto-utils is in fact
such a perl package but it doesn't follow the usual perl package naming format.
Since perl-Crypt-IDEA does not have a dependency on any other package owning
these directories, it's correct that it owns them itself.
Updated package:
Spec URL:
http://www.city-fan.org/~paul/extras/perl-Crypt-IDEA/perl-Crypt-IDEA.spec
SRPM URL:
http://www.city-fan.org/~paul/extras/perl-Crypt-IDEA/perl-Crypt-IDEA-1.08...
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.