[Bug 22] smplayer - A graphical frontend for mplayer

http://bugzilla.rpmfusion.org/show_bug.cgi?id=22 Julian Sikorski <belegdol(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |belegdol(a)gmail.com Status|NEW |ASSIGNED --- Comment #1 from Julian Sikorski <belegdol(a)gmail.com&gt; 2008-02-23 09:57:59 --- I'll do a full review later, but here are the initial comments: 1. You need to use $RPM_BUILD_ROOT or %{buildroot}, do not use both in one spec. 2. Could %{?_smp_mflags} be added? 3. Vendor should be rpmfusion, not livna. 4. Desktop file contains MimeType entry, so you need to update the desktop database: http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#head-de6770dd98... 5. You are not using the latest scriptlet for updating the gtk icon cache: http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#head-7103f6c38d... -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.