Comment # 15 on bug 4293 from
The following require no response:

1) Was going to point out the specfile needed these:
>Requires(postun): gtk-update-icon-cache shared-mime-info
>Requires(posttrans): gtk-update-icon-cache shared-mime-info

but then I saw this:
https://fedoraproject.org/wiki/Packaging:Scriptlets?rd=Packaging:ScriptletSnippets#Icon_Cache

It makes the claim the package is easier to use if we don't require it so
nevermind.

2) rpmlint incorrect-fsf-address errors. I just went through this with my own
project, and they are fairly easy to fix upstream. However, after browsing the
project site, the project does not appear to be active. If you have not done so
already, recommend you make an attempt to contact the author about the
incorrect gpl mailing address so we can say we did our due diligence and then
move on.

3) I've read the comments surrounding the hicolor-icon-theme issue, including
the reference link. My assumption is this issue has been resolved, since your
change resulted in no further comments.

4) fedora-review looks good, hasn't changed from the original output already
shown

Action items:

1) mv, mkdir, & cp are part of coreutils, so we should buildrequres coreutils
2) mv ,mkdir, & cp should be referred to by their macro names: %{__mv},
%{__mkidr}, and %{__cp}. Touch does not have a macro.

That's it. Everything else looks good. I'll approve the review as soon as these
small changes are made.


You are receiving this mail because: