[Bug 21] kmediafactory - A template based DVD authoring tool
http://bugzilla.rpmfusion.org/show_bug.cgi?id=21
Manuel Wolfshant <wolfy(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |wolfy(a)fedoraproject.org
AssignedTo|rpmfusion-package- |wolfy(a)fedoraproject.org
|review(a)rpmfusion.org |
--- Comment #2 from Manuel Wolfshant <wolfy(a)fedoraproject.org> 2008-02-25 00:47:16
---
Here are a list of modifications which I think that are needed before being
good to go:
- Use of buildroot is not consistant: in %clean $RPM_BUILD_ROOT should be
replaced with %{buildroot}
- desktop-file-utils must be added as BR (in order to provide
desktop-file-install)
- in desktop-file-install vendor should be "rpmfusion"
- desktop file: the Categories tag should not contain Application any more
because it is no longer valid
(http://standards.freedesktop.org/menu-spec/latest/apa.html)
- missing update-desktop-database, update-mime-database and
gtk-update-icon-cache (see
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#head-de6770dd98...)
in %post/%postun
Basically, you should add:
%post
update-desktop-database &> /dev/null ||:
update-mime-database %{_datadir}/mime &> /dev/null || :
touch --no-create %{_datadir}/icons/hicolor || :
if [ -x %{_bindir}/gtk-update-icon-cache ]; then
%{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || :
fi
%postun
update-desktop-database &> /dev/null ||:
update-mime-database %{_datadir}/mime &> /dev/null || :
touch --no-create %{_datadir}/icons/hicolor || :
if [ -x %{_bindir}/gtk-update-icon-cache ]; then
%{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || :
fi
%postun
I'll post a full review tomorrow, once I get a chance to also test the program
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.