[Bug 26] Review request: dvbcut - Clip and convert DVB transport streams to MPEG2 program streams

http://bugzilla.rpmfusion.org/show_bug.cgi?id=26 Andrea Musuruane <musuruan(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC|musuruan(a)gmail.com | --- Comment #14 from Andrea Musuruane <musuruan(a)gmail.com&gt; 2008-12-15 17:38:29 --- Some quick notes: * Compile process does not use {%optflags}. At least this is what I see when compiling the first file because... * ...it does not build at least under F9/i386. * You may want to have a look at these patches: http://viewcvs.gentoo.org/viewcvs.py/gentoo-x86/media-video/dvbcut/files/ * Why are packaging an svn snapshot? What are the pro's against latest release? Is this snapshot stable? Is a more recent snapshot better than the one used? * Missing Requires: hicolor-icon-theme. This is required because %{_datadir}/icons/hicolor/ directories are owned by this package. * Desktop file has the following problems: - Icon=dvbcut.logo.24x24 In this way, 16x16 and 32x32 icons will never be used. Install the icons with the same name under different directory and edit the Icon entry accordingly. - X-Desktop-File-Install-Version=0.4 This is something that should write desktop-file-install and should not be present in the source. - Name[en_AU]=dvbcut I think this is not needed. It is the same as the default name * Desktop file install should not be installed with a vendor name. * The conditional based on Fedora version should be removed since in less than a month all Fedora maintained versions will be > 8. * If there are no translations, remove the related commented lines. -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.