[Bug 436] Review request: moonlight - Moonlight is an open source implementation of Microsoft Silverlight for Unix systems
http://bugzilla.rpmfusion.org/show_bug.cgi?id=436
--- Comment #43 from Orcan Ogetbil <oget.fedora(a)gmail.com> 2009-07-03 00:13:48 ---
(In reply to comment #41)
(In reply to comment #40)
> ! The moonlight in Fedora 11 is compiled with --enable-moonlight=yes. So you
> may want to enable the "with_managed" for Fedora > 11.
No, I don't want. Please read previous comment in this bug.
Then either remove those bits from the specfile, or make them work properly for
users who want to do custom builds from your SPRM.
> * The %doc for all subpackages are the same, which results in
duplicate
> files. Please list those files in the appropriate package only.
There is not duplications. RPM know how to manage them because he is aware
there are the same files, not duped ones. There is no warning about then and
they install smoothly. Try it if you are interested.
Yes, there are duplications. Same files go to all packages, which is not
allowed (by a recent FPC decision). Put them only into the main package.
>
> * Additionally the files and directories
> ./plugin/TODO: ASCII English text
> [...]
> should probably go to appropriate %docs.
Not really as explained
as explained where?
> * The file LICENSE indicates different licenses for different parts. Please
> use the appropriate license(s) for each package
Maybe I'll do it if I feel motivated with the package approval.
Ok, but the package will not get approved if you don't address this. Your
choice...
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.