Comment # 7 on bug 4393 from Andrew Bauer

(In reply to Vasiliy Glazov from comment #4)
> CentOS/RHEL 6 must have %make_build macro. You not need to define it
> manually.

I took a harder look at where %make_build might get defined on CentOS6. It does
not ship with the stock rpm package like newer redhat distros. Instead, the
macro definition is part of the epel-rpm-macros package. There we go. Mystery
solved.

(In reply to Vasiliy Glazov from comment #5)
> Next suggestions:
> 1. %global zmuid $(id -un)
> %global zmgid $(id -gn)
> Not used and can be removed.
> 
> 2. If COPYING - is a license text it must be not in %doc, but
> %license COPYING

Good catch. These changes have been applied.


(In reply to Vasiliy Glazov from comment #6)
> And it is realy require vlc-devel?

There are currently no Requires for vlc-devel in the spec file, but there are
BuildRequires for vlc-devel and ffmpeg-devel. ZoneMinder searches for the
header files of these libraries, and, it if finds them, it links against them.
Currently, if it does not find them, it excludes the code that makes ffmpeg
and/or vlc api calls. In the future, zoneminder's dependence on ffmpeg will
likely become required instead of optional. As a side note, today, zoneminder
can be built w/o ffmpeg support, but that makes zoneminder incompatible with
nearly all modern ip cameras (i.e. virtually useless). This happens to be the
driving force behind why Fedora understandably does not intend to host
zoneminder any longer.


(In reply to Dominik 'Rathann' Mierzejewski from comment #3)
> (In reply to Vasiliy Glazov from comment #1)
> [...]
> > 5. In %files section use %{_bindir}/* instead of one string for each file.
> 
> Sorry, but I don't agree with using wildcards unless there are many files
> there. You won't notice any new files there easily unless you run rpmdiff on
> the final package or check manually. You don't have to save every single
> byte of the spec file. It's better to be a little verbose and a lot more
> legible.

Since zoneminder has 19 executables, I tend to agree with this. I think showing
each executable under %files adds value.