[Bug 96] Review request: broadcom wireless kmod (wl-kmod)

http://bugzilla.rpmfusion.org/show_bug.cgi?id=96 Thorsten Leemhuis <fedora(a)leemhuis.info&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|2 |3 AssignedTo|rpmfusion-package- |fedora(a)leemhuis.info |review(a)rpmfusion.org | --- Comment #10 from Thorsten Leemhuis <fedora(a)leemhuis.info&gt; 2008-11-02 13:21:28 --- Packages look quite good; some mostly minor issues: = common issues = - I think the macro %define kmod_name wl looks odd and is not worth the trouble, as -- it's just use in one or two places per spec file -- it unlikely that the kmod name will change = broadcom-wl.spec = - I'd say the README (http://www.broadcom.com/docs/linux_sta/README.txt) should be part of the package, as it also contains a few informations for users (maybe the rest should get stripped) - Quoting from the README Is this a issue on Fedora? If yes then we should consider to blacklist the module. But I'd like to avoid this, as it makes adding this driver to live-cds harder (as we don't want to blacklist b43 in general) = wl-kmod.spec = - Please remove the #define buildforkernels current #define buildforkernels akmod stuff -- Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug.