[Bug 1252] Review request: swftools - SWF manipulation and generation utilities
http://bugzilla.rpmfusion.org/show_bug.cgi?id=1252
Orcan Ogetbil <oget.fedora(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |oget.fedora(a)gmail.com
Blocks|2 |3
AssignedTo|rpmfusion-package- |oget.fedora(a)gmail.com
|review(a)rpmfusion.org |
--- Comment #2 from Orcan Ogetbil <oget.fedora(a)gmail.com> 2010-06-26 23:54:22 ---
I made a full review on this. Here are my comments, notes:
! The patch is nice and clean, and can be upstreamed. Please provide a link in
the specfile as comment if you do so.
! Note that since you BR: pdflib-lite-devel, package has to go to
rpmfusion-nonfree.
- rpmlint is silent
? The package bundles a copy of xpdf which is available in Fedora. Is it
possible to patch it out?
* Parts of the software carry different licenses. For example:
lib/MD5.c is BSD
lib/action/actioncompiler.c is LGPLv2+
lib/action/swfcompiler.tab.c is GPLv3+
I didn't find any license conflicts though. Please fish these all out and list
them in the License tag of the specfile with comments about which files belong
to what license.
! Please try to make the description span 80 columns as much as possible (it is
set to 70 columns right now).
--
Configure bugmail: http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.