[Bug 4441] New: Review request: discord - All-in-one voice and text chat for gamers

https://bugzilla.rpmfusion.org/show_bug.cgi?id=4441 Bug ID: 4441 Summary: Review request: discord - All-in-one voice and text chat for gamers Product: Package Reviews Version: Current Hardware: x86_64 OS: GNU/Linux Status: NEW Severity: enhancement Priority: P1 Component: Review Request Assignee: rpmfusion-package-review(a)rpmfusion.org Reporter: seancallaway(a)gmail.com CC: rpmfusion-package-review(a)rpmfusion.org SPEC URL: https://seansblag.com/software/discord/discord.spec SRPM URL: https://seansblag.com/software/discord/discord-0.0.1-1.fc25.src.rpm DESCRIPTION: Discord is a free-of-cost proprietary VoIP application designed for gaming communities. WHY NOT IN FEDORA? Discord is a proprietary application *and* relies on nonfree libraries (such as ffmpeg), which the developer has bundled into the application. RPMLINT OUTPUT (SRPM): discord.src: W: spelling-error Summary(en_US) gamers -> gamer, games, tamers discord.src: W: invalid-license Proprietary 1 packages and 0 specfiles checked; 0 errors, 2 warnings. RPMLINT OUTPUT (RPM): discord.x86_64: W: spelling-error Summary(en_US) gamers -> gamer, games, tamers discord.x86_64: W: invalid-license Proprietary discord.x86_64: W: binaryinfo-readelf-failed /usr/lib64/discord/resources/bootstrap/discord_voice.zip readelf: Error: Not an ELF file - it has the wrong magic bytes at the start discord.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/discord/Discord ['$ORIGIN', '$ORIGIN/lib/'] discord.x86_64: W: binaryinfo-readelf-failed /usr/lib64/discord/resources/bootstrap/discord_toaster.zip readelf: Error: Not an ELF file - it has the wrong magic bytes at the start discord.x86_64: W: binaryinfo-readelf-failed /usr/lib64/discord/resources/bootstrap/discord_utils.zip readelf: Error: Not an ELF file - it has the wrong magic bytes at the start discord.x86_64: W: no-documentation discord.x86_64: W: no-manual-page-for-binary Discord discord.x86_64: W: desktopfile-without-binary /usr/share/applications/discord.desktop /usr/bin/Discord JUSTIFICATIONS FOR ERRORS AND WARNINGS: * spelling-error: gamers is the proper plural of gamer. * invalid-license: rpmlint doesn't seem to support nonfree licenses * binaryinfo-readelf-failed: It's right. There's aren't ELF binaries, as they're ZIP files. Not sure how to remove this error, but am more than willing to do something to fix this. * binary-or-shlib-defines-rpath: The developer has built their proprietary binary to use bundled libraries. It's not ideal, but it's what they've done. I can try to convince them to just include those libs as a requirement in their Linux release. * no-documentation and no-manual-page-for-binary: No documentation is provided for Discord outside of their website. * desktopfile-without-binary: /usr/bin/Discord is a symlink to /usr/lib64/discord/Discord due to the bundled libraries. NOTES: This is my first RPMFusion package (and first desktop application package), but not my first package. I package re2c and openvpn-auth-ldap for EPEL. -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.