Re: fceux
Andrea,
I followed your recommendations to strip the source of the Lua files, but now it will not
compile and gives this error:
src/lua-engine.cpp: In function 'void CallRegisteredLuaLoadFunctions(int, const
LuaSaveData&)':
src/lua-engine.cpp:1064: error: invalid use of incomplete type 'struct lua_State'
src/fceulua.h:43: error: forward declaration of 'struct lua_State'
src/lua-engine.cpp: In function 'void toCStringConverter(lua_State*, int, char*&,
int&)':
Based on some of the files I had patch after I stripped the lua out of the source, it
seems that this code needs one of the internal headers of lua from the static source,
lstate.h. At least they are using the latest lua, but since I'm not much a programmer,
I would not know where to begin debugging it so it will build using the system proved lua.
I have sent an E-Mail to upstream for advice, so we'll see if they have any
suggestions. I have also cc:'d this mail to the list in case anyone else in RPM Fusion
might have some suggestions. I know you've been busy (I have been too), so no worries
if you can't get to this right away.
Regards,
John
--- On Sun, 1/10/10, Andrea Musuruane <musuruan(a)gmail.com> wrote:
From: Andrea Musuruane <musuruan(a)gmail.com>
Subject: Re: fceux
To: "John Arntz" <jsarntz(a)yahoo.com>
Date: Sunday, January 10, 2010, 10:10 AM
Ho John,
On Sat, Jan 9, 2010 at 5:52 PM, John Arntz <jsarntz(a)yahoo.com>
wrote:
> Upon closer inspection, the line commented out by sed
is:
>
> #env.Append(CCFLAGS = ['-Wall', '-Wno-write-strings',
'-Wno-sign-compare', '-O2', '-Isrc/lua/src'])
>
> it looks like the '-Isrc/lua/src' is necessary to
point the compiler to the sources to support lua. I made a
patch that patches lua-engine.cpp that points to the files
that it has trouble finding and it will build with that. But
I was wondering now, if it would be better to put
'-Isrc/lad/src' someplace else in SConstruct and patch it?
You must not use the local supplied LUA libriary, but you
must always
use the system one. The fact that LUA is now bundle in
fceux sources
is a new (and very wrong thing).
Therefore I suggest you to:
1. see if the local source copy of LUA is equal to the one
Fedora provides
2. remove the local source dir of LUA in %prep to be sure
not to use it
3. patch fceux to use the system LUA
>
https://sites.google.com/site/subwaysrpms/files/fceux-2.1.2-1.fc12.src.rp...
>
> https://sites.google.com/site/subwaysrpms/files/fceux.spec?attredirects=0...
>
> Here are the links to my SRPM and .spec files. Once
everything gets worked out I plan to submit it for review to
RPMFusion.
I'll try to have a deeper look later this week. Sorry, I
have a lack
of free time right now.
Bye,
Andrea.