2013/11/22 Alec Leamas <leamas.alec@gmail.com>
With the lpf package under way to fedora stable and the first lpf-* packages on their way into rpmfusion  there is an issue with the review process fo llpf-* packages (an lpf package).

An lpf package is basically a wrapper for  the spec for a target package. E. g. lpf-skype contains lpf.skype.spec and skype.spec.in (see [1]).

Formally, when reviewing the lpf-skype package a reviewer should review the package spec i. e., lpf-skype.spec. However, this is just some copy-paste code which is more or less the same for all lpf packages. It's still evolving, but it should be  more or less a non-issue when reviewing.
The only issue I expect is when the package is only available for a subset of architectures, Given that it's often pre-build binaries, I guess most lft packages should be made ExclusiveArch to match

I have no problem having to say the the real review is the bundled spec.in that's been said.
I should be common sense that guidelines should en-light.

Unrelated question. Can lpf be made to rebuild existing packages from src.rpm (provided as sources repositories) using --with --without RPM conditionals ? I think it would be very usefull.
Also, when I first thought about a feature like lpf; I expected non-redistributable softwares to be provided as nosrc.rpm from the source code repository instead. (so handled like any others packages in SCM)...


Nicolas (kwizart)