http://bugzilla.rpmfusion.org/show_bug.cgi?id=1786
--- Comment #9 from Attila Zsolt Sajo <sajozsattila(a)yahoo.com> 2011-06-15 15:14:45
---
(In reply to comment #4)
I can't accept review responsibilty at this time. Too many irons
in the fire.
But I'll suggest some fixes.
All 3 macros at the top of your spec file are unnecessary. Both %{name} and
%{version} will get assigned automatically from the Name: and Version: fields.
Since %{release} is not used anywhere else but the Release: field it's not
needed either.
BuildRoot: and %clean are not needed at all if you're not going to build for
EPEL.
Remove the unneeded newline after %description.
Under %setup I don't think you need the -n option. It should look in
%{name}-%{version} by default.
Under %install just use "make" you don't need to use the macro for it. As
I
understand it the macros are for situation where you need to override the
default behavior.
That's all I can see in a very quick review.
I fixed the spec file, and I uploaded in the same address.
(
http://sajozsattila.co.uk/Files/wbar.spec) And there is no more
unstripped-binary-or-object error.
--
Configure bugmail:
http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.