http://bugzilla.rpmfusion.org/show_bug.cgi?id=396
--- Comment #15 from Eric Moret <eric.moret(a)gmail.com> 2009-04-25 07:24:24 ---
Thank you for spending the time reviewing this package. Please see inline
below.
(In reply to comment #14)
Thanks. A few comments:
* Upstream provides a tarball on their website:
http://code.google.com/p/paint-mono/downloads/list
Any reason why that one is not used?
Upstream posted its first file on March 25th while this package was submitted
in February. I have since moved to using upstreamĀ“s release.
* Is it really not possible to replace the offending artwork by some
free
artwork?
I would like to think so, there is an open request for icon replacement at the
fedora wiki
https://fedoraproject.org/wiki/Artwork/DesignService#Paint.NET_icon_repla...
* Any possible license issues with Sources 3-6 ? You should explain
where and
how to get them in the SPEC file.
I created a script to extract those icons.
* Similarly, the patches should be explained, and if they are not
Fedora
specific, sent upstream. Links from their upstream should be provided.
It *seems* to me the change to using upstreamĀ“s tarball has taken care of this
patch therefore I have removed this patch but I do not currently have access to
an x86_64 box to test. Prior to including this patch I had also created an
upstream bug as seen at the following link:
http://code.google.com/p/paint-mono/issues/detail?id=20
* Packages containing pkgconfig(.pc) files must 'Requires:
pkgconfig' (for
directory ownership and usability).
ok
* Please don't use a --vendor flag on desktop-file-install
I had to include this for me to be able to build on CentOS5 which is one of my
target systems. What is the workaround there?
* %attr(0644,root,root) is not needed
! %dir %{_libdir}/%{name}
%{_libdir}/%{name}/*
can be replaced by just
%{_libdir}/%{name}/
ok
* Any reason why you use
./configure --prefix=%{_prefix} --libdir=%{_libdir}
instead of just
%configure
?
The configure script provided by upstream only supported the above 2 options
(has moved to only supporting --prefix now)
ok
--
Configure bugmail:
http://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.