[Bug 4009] Review request: qmplay2 - A Qt based media player, streamer and downloader
https://bugzilla.rpmfusion.org/show_bug.cgi?id=4009
--- Comment #16 from Vasiliy Glazov <vascom2(a)gmail.com> 2016-08-23 09:08:45 CEST
---
1. Drop Patch0 at all because not using compile_unix script.
2. Change %setup -q -n %{pname}-src-%{version} to
%autosetup -n %{pname}-src-%{version}
3. Change
%{_qt5_qmake} \
QT_SUFFIX=-qt5 \
QMAKE_CFLAGS="%{optflags}" \
QMAKE_CXXFLAGS="%{optflags}" \
QMAKE_LFLAGS="%{optflags}"
to
%qmake_qt5
Also, as I see in README.md, for compile in Linux recommended use cmake. May be
change build section to %cmake approach and just use %make_install macro in
%install section?
4. Change
%dir %{_datadir}/%{name}/
%dir %{_datadir}/%{name}/lang
to
%{_datadir}/%{name}
5. Change
%doc %{_datadir}/%{name}/AUTHORS
%doc %{_datadir}/%{name}/ChangeLog
%doc %{_datadir}/%{name}/README.md
%doc %{_datadir}/%{name}/TODO
%license %{_datadir}/%{name}/LICENSE
to
%doc AUTHORS ChangeLog README.md TODO
%license LICENSE
6. Change %{_mandir}/man1/%{pname}.1.gz to %{_mandir}/man1/%{pname}.1.*
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.