Comment # 20 on bug 4393 from Andrew Bauer

I can absolutely knock those those changes out, but what follows are some
questions to help get it right in one pass.

(In reply to Xavier Bachelot from comment #19)
> - Would it be possible to have one sub-package for httpd and another for
> nginx ? 

Building a zoneminder-nginx package is brand new, has only been tested on my
raspberry pi, and I am not yet aware of a demand for this, although I suspect
there will be a demand once others get wind of it. What I'm getting at is I
don't see nginx support as something we need to implement initially. Are you
okay with leaving these unused bits in the specfile for now or would you rather
I finish this work sooner rather than later?

A sub-package build has definitely been on my mind for some time now, for a
number of reasons. An installed ZoneMinder package runs under the name of the
web account user, so as you might expect, during the build, file/folder
permissions, config file entries, and database entries are set to that account
name. What I have not yet taken the time to do is determine an elegant,
non-hackish, way to crank out a zoneminder-apache and zoneminder-nginx package
in a single pass. If this description sounds like another package you are
already aware of, then by all means let me know. I'll take a look at that spec
file to see if there is anything I can borrow.


> - Isn't "%global _hardened_build 1" the default anyway ?
>   

I added this a couple years ago at the request of a Fedora packager. At the
time, it was definitely not set, as I had to make a change upstream to get zm
to build successfully with this on. Maybe it is today? I can ping the guy who
requested this and see if he can shed some light.

> - Source: should be a full URL. I realize that 1.30.1 was not released nor
> even tagged, I assume that's the reason, but this needs to be fixed. You
> might also want to use the more common Source0 rather than Source.
> 

I can certainly set that to a full url, but just to confirm, since zoneminder
uses a git submodule, would this be what you had in mind?
https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Git_Submodules

Which basically means set the submodule up as Source1, unpack it, and then move
it into submodule target folder.


All the rest of the changes seem like merely coding style changes, and I'll
knock them out as time permits.