Comment # 19 on bug 4041 from Mark Harfouche

Sorry, the lastest version is untested. Don't have access to Fedora at the
moment.

(In reply to Dominik 'Rathann' Mierzejewski from comment #18)
> (In reply to Nicolas Chauvet from comment #14)
> > (In reply to Mark Harfouche from comment #13)
> > > Reviving this bug because I think I addressed the previous issues. Thanks
> > > Dominik.
> > ...
> > > This is my first RPM Fusion Package. I am seeking a sponsor.
> > Rathann can sponsor you.
> 
> I could, but I'd like to see some (informal) package reviews by Mark first.
> 

Ok, I'll get on the mailing list. I'll likely be super busy before Sept 6th. So
there will be a delay.

(In reply to Nicolas Chauvet from comment #16)
> (In reply to Mark Harfouche from comment #15)
> ...
> > > Fedora default to i686 nowadays (-march), so if this binary is really built
> > > for i486, it could lead to issue. Anyone tested it there ? If it doesn't
> > > work one could also drop 32bit support.
> > Hoenstly, I don't own a 32bit computer anymore. I think it is i486 because
> Then maybe you can drop the i486 package and only package the x86_64 as
> ExclusiveArch: x86_64.
> 
> If any end-user would need the 32bit support, then they can contribute the
> packaging change.
> 
> Anyway, both options are possible.

32 bit support dropped.

> Please try to use the %global defines on the top of the spec file (they have
> been added twice).

Done

> libMendeley.so is packaged in a -devel sub-package, but there is no header.
> Are you sure this symlink to the library isn't used at runtime ?

-devel removed

> libPDFNetC is a library from another project. If you are using the pre-built
> version from Mendeley, it will conflicts if both packages are installed.
> https://github.com/PDFTron/PDFNetWrappers
> 
> Instead you need to either:
> - Package libPDFNetC (in fedora) and use the version built from source.
> - Use a dedicated path, not registered to the system linker, so Mendeley can
> find it's libraries. (and add something like /usr/lib64/Mendeley to
> LD_LIBRARY_PATH).
I think we can put this in libexec right?
I'll try to test things on my Fedora computer this weekend. 

(In reply to Dominik 'Rathann' Mierzejewski from comment #17)
> You can find my latest spec+patch here:
> https://rathann.fedorapeople.org/nosrc/mendeleydesktop/
Thanks! Found some missing bundled libraries. You are very thorough.