[Bug 2979] Review request: steam - Installer for the Steam software distribution service
https://bugzilla.rpmfusion.org/show_bug.cgi?id=2979
Simone Caronni <negativo17(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|2 |3
AssignedTo|rpmfusion-package-review@rp |leamas.alec(a)gmail.com
|mfusion.org |
--- Comment #29 from Simone Caronni <negativo17(a)gmail.com> 2013-10-23 15:03:33 CEST
---
Issues:
[!]: Useful -debuginfo package or justification otherwise.
Disabling debuginfo is fine here, but needs a justification comment.
[!]: Requires correct, justified where necessary.
[!]: Package must own all directories that it creates.
/usr/lib/udev and /usr/lib/udev/rules.d are owned by systemd,
/etc/profile.d by setup. These need to be Require:'d.
[!]: Package contains no bundled libraries without FPC exception.
The bundled libraries need to be in package according to the license.
Still, they need a bundling exception. Request on rpmfusion-developers.
[!]: Valid rpmlint warnings, please fix:
name-repeated-in-summary C Steam
wrong-file-end-of-line-encoding
/usr/share/doc/steam/steam_install_agreement.txt
steam.src:35: W: macro-in-comment %{name}
steam.src:36: W: macro-in-comment %{_isa}
[!]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
-->OK for rpmfusion, though. Please add some kind of reference to
the license in a comment above it.
--
Configure bugmail: https://bugzilla.rpmfusion.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
You are the assignee for the bug.