Comment # 16 on bug 4441 from
(In reply to Nicolas Chauvet from comment #12)
> (In reply to Andrew Bauer from comment #11)
> ...
> > We should probably add the requires shown in this spec file, but add them
> > one per line please:
> > https://github.com/RPM-Outpost/discord/blob/master/discord-stable.spec
> > Gives props to the electronwill for figuring that part out.
> Please reminds to use the %{_isa} notation for each dependencies (one by
> line for better readability). 

Done, but reviewing whether libstdc++ is still required since their move to
clang.

> Some dependencies can be automatically detected if you remove AutoReqProv:  
> no
> Also BuildRequires:  libXScrnSaver is probably Requires:
> libXScrnSaver%{_isa} instead.

Looking at the spec file that Andrew linked, this isn't even listed, which
makes me want to test it without.

> Please use desktop-file-validate
> https://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-
> install_usage

Is validate preferred over install? The desktop-file-install looks like it
could replace my need for sed in the %prep section.

> Also please consider to provide appdata files
> https://fedoraproject.org/wiki/Packaging:AppData

Will look into this.

> As this is a pre-built binary package, you need to use both of theses macros:
> ---
> %global        debug_package %{nil}
> %global        __strip /bin/true
> ---

Added.

A new SRPM has been generated from the new SPEC file and is available at:
https://seansblag.com/software/discord/discord-0.0.2-1.fc26.src.rpm


You are receiving this mail because: